Skip to content

Commit 376e160

Browse files
committed
fix: importLoaders for webpack prod to ensure sass gets called for css-module composes: expressions
1 parent 2b9e65d commit 376e160

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

packages/react-scripts/config/webpack.config.prod.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ module.exports = {
238238
loader: require.resolve("css-loader"),
239239
options: {
240240
modules: true,
241-
importLoaders: 1,
241+
importLoaders: 3,
242242
minimize: true,
243243
sourceMap: shouldUseSourceMap,
244244
localIdentName: "[name]__[local]__[hash:base64:5]"
@@ -353,7 +353,7 @@ module.exports = {
353353
{
354354
loader: require.resolve("css-loader"),
355355
options: {
356-
importLoaders: 1,
356+
importLoaders: 3,
357357
minimize: true,
358358
sourceMap: shouldUseSourceMap
359359
}

packages/react-scripts/package.json

+5-10
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
22
"name": "@tandem.ly/react-scripts",
33
"version": "1.0.18",
4-
"description": "Tandem.ly Custom Configuration and scripts for Create React App.",
4+
"description":
5+
"Tandem.ly Custom Configuration and scripts for Create React App.",
56
"repository": "Tandemly/create-react-app",
67
"license": "MIT",
78
"engines": {
@@ -10,13 +11,7 @@
1011
"bugs": {
1112
"url": "https://github.com/Tandemly/create-react-app/issues"
1213
},
13-
"files": [
14-
"bin",
15-
"config",
16-
"scripts",
17-
"template",
18-
"utils"
19-
],
14+
"files": ["bin", "config", "scripts", "template", "utils"],
2015
"bin": {
2116
"react-scripts": "./bin/react-scripts.js"
2217
},
@@ -51,6 +46,7 @@
5146
"postcss-loader": "2.0.6",
5247
"promise": "8.0.1",
5348
"react-dev-utils": "^4.1.0",
49+
"resolve-url-loader": "^2.1.0",
5450
"sass-loader": "^6.0.6",
5551
"style-loader": "0.19.0",
5652
"sw-precache-webpack-plugin": "0.11.4",
@@ -62,8 +58,7 @@
6258
},
6359
"devDependencies": {
6460
"react": "^15.5.4",
65-
"react-dom": "^15.5.4",
66-
"resolve-url-loader": "^2.1.0"
61+
"react-dom": "^15.5.4"
6762
},
6863
"optionalDependencies": {
6964
"fsevents": "1.1.2"

0 commit comments

Comments
 (0)