Skip to content

Commit 24cf27c

Browse files
committed
In JavaScriptEngineSwitcher.ChakraCore no longer supports a .NET Core App 2.1
1 parent 0b3259d commit 24cf27c

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

src/JavaScriptEngineSwitcher.ChakraCore/ChakraCoreJsEngine.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
using System;
2-
#if NET45_OR_GREATER || NETSTANDARD || NETCOREAPP2_1
2+
#if NET45_OR_GREATER || NETSTANDARD
33
using System.Runtime.InteropServices;
44
#endif
55
using System.Text;

src/JavaScriptEngineSwitcher.ChakraCore/Helpers/EncodingHelpers.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#if NET45_OR_GREATER || NETSTANDARD || NETCOREAPP2_1
1+
#if NET45_OR_GREATER || NETSTANDARD
22
using System.Buffers;
33
#endif
44
using System.Text;
@@ -38,7 +38,7 @@ public static string UnicodeToAnsi(string value, out int byteCount)
3838

3939
try
4040
{
41-
#if NET45_OR_GREATER || NETSTANDARD || NETCOREAPP2_1
41+
#if NET45_OR_GREATER || NETSTANDARD
4242
result = ConvertStringInternal(utf8Encoding, ansiEncoding, value, valueLength, buffer, bufferLength);
4343
#else
4444
utf8Encoding.GetBytes(value, 0, valueLength, buffer, 0);
@@ -54,7 +54,7 @@ public static string UnicodeToAnsi(string value, out int byteCount)
5454

5555
return result;
5656
}
57-
#if NET45_OR_GREATER || NETSTANDARD || NETCOREAPP2_1
57+
#if NET45_OR_GREATER || NETSTANDARD
5858

5959
private static unsafe string ConvertStringInternal(Encoding srcEncoding, Encoding dstEncoding, string s,
6060
int charCount, byte[] bytes, int byteCount)
@@ -63,7 +63,7 @@ private static unsafe string ConvertStringInternal(Encoding srcEncoding, Encodin
6363
fixed (byte* pBytes = bytes)
6464
{
6565
srcEncoding.GetBytes(pString, charCount, pBytes, byteCount);
66-
#if NET471 || NETSTANDARD || NETCOREAPP2_1
66+
#if NET471 || NETSTANDARD
6767
string result = dstEncoding.GetString(pBytes, byteCount);
6868

6969
return result;

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<Product>JS Engine Switcher: ChakraCore</Product>
55
<VersionPrefix>3.12.6</VersionPrefix>
6-
<TargetFrameworks>net40-client;net45;net471;netstandard1.3;netstandard2.0;netcoreapp2.1;netstandard2.1</TargetFrameworks>
6+
<TargetFrameworks>net40-client;net45;net471;netstandard1.3;netstandard2.0;netstandard2.1</TargetFrameworks>
77
<NetStandardImplicitPackageVersion Condition=" '$(TargetFramework)' == 'netstandard1.3' ">1.6.0</NetStandardImplicitPackageVersion>
88
<OutputType>Library</OutputType>
99
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
@@ -31,7 +31,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
3131
* JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</Description>
3232
<PackageTags>$(PackageCommonTags);ChakraCore</PackageTags>
3333
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
34-
<PackageReleaseNotes>Improved a implementation of the `Dispose` method.</PackageReleaseNotes>
34+
<PackageReleaseNotes>No longer supports a .NET Core App 2.1.</PackageReleaseNotes>
3535
</PropertyGroup>
3636

3737
<ItemGroup>

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsPropertyId.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
using System;
2-
#if NET45_OR_GREATER || NETSTANDARD || NETCOREAPP2_1
2+
#if NET45_OR_GREATER || NETSTANDARD
33
using System.Buffers;
44
using System.Runtime.InteropServices;
55
#endif

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsValue.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
using System;
2-
#if NET45_OR_GREATER || NETSTANDARD || NETCOREAPP2_1
2+
#if NET45_OR_GREATER || NETSTANDARD
33
using System.Buffers;
44
#endif
55
using System.Runtime.InteropServices;

src/JavaScriptEngineSwitcher.ChakraCore/ScriptDispatcher.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
using System;
22
using System.Collections.Generic;
33
using System.Runtime.CompilerServices;
4-
#if NET45_OR_GREATER || NETSTANDARD || NETCOREAPP2_1
4+
#if NET45_OR_GREATER || NETSTANDARD
55
using System.Runtime.ExceptionServices;
66
#endif
77
using System.Threading;
@@ -137,7 +137,7 @@ private void ExecuteTask(ScriptTask task)
137137
Exception exception = task.Exception;
138138
if (exception != null)
139139
{
140-
#if NET45_OR_GREATER || NETSTANDARD || NETCOREAPP2_1
140+
#if NET45_OR_GREATER || NETSTANDARD
141141
ExceptionDispatchInfo.Capture(exception).Throw();
142142
#elif NET40
143143
exception.PreserveStackTrace();

src/JavaScriptEngineSwitcher.ChakraCore/readme.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
=============
3232
RELEASE NOTES
3333
=============
34-
Improved a implementation of the `Dispose` method.
34+
No longer supports a .NET Core App 2.1.
3535

3636
=============
3737
DOCUMENTATION

0 commit comments

Comments
 (0)