Skip to content

Commit fef69f8

Browse files
committed
In JavaScriptEngineSwitcher.Jint added support of Jint version 3.0.0 Beta 2040
1 parent 559c474 commit fef69f8

File tree

5 files changed

+15
-39
lines changed

5 files changed

+15
-39
lines changed

global.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"sdk": {
3-
"version": "6.0.302"
3+
"version": "6.0.400"
44
}
55
}

src/JavaScriptEngineSwitcher.Jint/JavaScriptEngineSwitcher.Jint.csproj

+3-5
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,15 @@
1818
<Import Project="../../build/nuget-for-dotnet-lib.props" />
1919

2020
<PropertyGroup>
21-
<Description>JavaScriptEngineSwitcher.Jint contains adapter `JintJsEngine` (wrapper for the Jint JavaScript Engine (http://github.com/sebastienros/jint) version 3.0.0 Beta 2039).</Description>
21+
<Description>JavaScriptEngineSwitcher.Jint contains adapter `JintJsEngine` (wrapper for the Jint JavaScript Engine (http://github.com/sebastienros/jint) version 3.0.0 Beta 2040).</Description>
2222
<PackageTags>$(PackageCommonTags);Jint</PackageTags>
2323
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_Jint_Logo128x128.png</PackageIconFullPath>
24-
<PackageReleaseNotes>1. Jint was updated to version 3.0.0 Beta 2039;
25-
2. No longer supports a .NET Framework 4.6.1;
26-
3. Added support of .NET Framework 4.6.2.</PackageReleaseNotes>
24+
<PackageReleaseNotes>Jint was updated to version 3.0.0 Beta 2040.</PackageReleaseNotes>
2725
</PropertyGroup>
2826

2927
<ItemGroup>
3028
<PackageReference Include="AdvancedStringBuilder" Version="0.1.0" />
31-
<PackageReference Include="Jint" Version="3.0.0-beta-2039" />
29+
<PackageReference Include="Jint" Version="3.0.0-beta-2040" />
3230

3331
<ProjectReference Include="../JavaScriptEngineSwitcher.Core/JavaScriptEngineSwitcher.Core.csproj" />
3432
</ItemGroup>

src/JavaScriptEngineSwitcher.Jint/JintJsEngine.cs

+5-25
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
using OriginalParsedScript = Esprima.Ast.Script;
1616
using OriginalParser = Esprima.JavaScriptParser;
1717
using OriginalParserException = Esprima.ParserException;
18-
using OriginalParserOptions = Esprima.ParserOptions;
1918
using OriginalRecursionDepthOverflowException = Jint.Runtime.RecursionDepthOverflowException;
2019
using OriginalRuntimeException = Jint.Runtime.JintException;
2120
using OriginalStatementsCountOverflowException = Jint.Runtime.StatementsCountOverflowException;
@@ -52,7 +51,7 @@ public sealed class JintJsEngine : JsEngineBase
5251
/// <summary>
5352
/// Version of original JS engine
5453
/// </summary>
55-
private const string EngineVersion = "3.0.0 Beta 2039";
54+
private const string EngineVersion = "3.0.0 Beta 2040";
5655

5756
/// <summary>
5857
/// Jint JS engine
@@ -153,22 +152,6 @@ public JintJsEngine(JintSettings settings)
153152
}
154153

155154

156-
/// <summary>
157-
/// Creates a Esprima .NET parser options with document name and special settings for the Jint
158-
/// </summary>
159-
/// <param name="documentName">Document name</param>
160-
/// <returns>Esprima .NET parser options with document name and special settings for the Jint</returns>
161-
private static OriginalParserOptions CreateParserOptions(string documentName)
162-
{
163-
var parserOptions = new OriginalParserOptions(documentName)
164-
{
165-
AdaptRegexp = true,
166-
Tolerant = true
167-
};
168-
169-
return parserOptions;
170-
}
171-
172155
#region Mapping
173156

174157
/// <summary>
@@ -367,12 +350,11 @@ protected override IPrecompiledScript InnerPrecompile(string code, string docume
367350
{
368351
OriginalParsedScript parsedScript;
369352
string uniqueDocumentName = _documentNameManager.GetUniqueName(documentName);
370-
OriginalParserOptions parserOptions = CreateParserOptions(uniqueDocumentName);
371353

372354
try
373355
{
374-
var parser = new OriginalParser(code, parserOptions);
375-
parsedScript = parser.ParseScript();
356+
var parser = new OriginalParser();
357+
parsedScript = parser.ParseScript(code, uniqueDocumentName);
376358
}
377359
catch (OriginalParserException e)
378360
{
@@ -391,15 +373,14 @@ protected override object InnerEvaluate(string expression, string documentName)
391373
{
392374
object result;
393375
string uniqueDocumentName = _documentNameManager.GetUniqueName(documentName);
394-
OriginalParserOptions parserOptions = CreateParserOptions(uniqueDocumentName);
395376

396377
lock (_executionSynchronizer)
397378
{
398379
OriginalValue resultValue;
399380

400381
try
401382
{
402-
resultValue = _jsEngine.Evaluate(expression, parserOptions);
383+
resultValue = _jsEngine.Evaluate(expression, uniqueDocumentName);
403384
}
404385
catch (OriginalParserException e)
405386
{
@@ -440,13 +421,12 @@ protected override void InnerExecute(string code)
440421
protected override void InnerExecute(string code, string documentName)
441422
{
442423
string uniqueDocumentName = _documentNameManager.GetUniqueName(documentName);
443-
OriginalParserOptions parserOptions = CreateParserOptions(uniqueDocumentName);
444424

445425
lock (_executionSynchronizer)
446426
{
447427
try
448428
{
449-
_jsEngine.Execute(code, parserOptions);
429+
_jsEngine.Execute(code, uniqueDocumentName);
450430
}
451431
catch (OriginalParserException e)
452432
{

src/JavaScriptEngineSwitcher.Jint/readme.txt

+2-4
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,12 @@
1313
===========
1414
JavaScriptEngineSwitcher.Jint contains adapter `JintJsEngine` (wrapper for the
1515
Jint JavaScript Engine (http://github.com/sebastienros/jint) version
16-
3.0.0 Beta 2039).
16+
3.0.0 Beta 2040).
1717

1818
=============
1919
RELEASE NOTES
2020
=============
21-
1. Jint was updated to version 3.0.0 Beta 2039;
22-
2. No longer supports a .NET Framework 4.6.1;
23-
3. Added support of .NET Framework 4.6.2.
21+
Jint was updated to version 3.0.0 Beta 2040.
2422

2523
=============
2624
DOCUMENTATION

test/JavaScriptEngineSwitcher.Tests/Jint/InteropTests.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ public void MappingHostErrorDuringRecursiveEvaluationOfFilesIsCorrect()
217217
Assert.StartsWith("Could not find file '", exception.Message);
218218
}
219219

220-
/*[Fact]
220+
[Fact]
221221
public void MappingCompilationErrorDuringRecursiveExecutionOfFilesIsCorrect()
222222
{
223223
// Arrange
@@ -248,11 +248,11 @@ public void MappingCompilationErrorDuringRecursiveExecutionOfFilesIsCorrect()
248248
// Assert
249249
Assert.NotNull(exception);
250250
Assert.Equal("Compilation error", exception.Category);
251-
Assert.Equal("Unexpected token ILLEGAL", exception.Description);
251+
Assert.Equal("Unexpected number", exception.Description);
252252
Assert.Equal("SyntaxError", exception.Type);
253253
Assert.Equal("second-file.js", exception.DocumentName);
254254
Assert.Equal(1, exception.LineNumber);
255-
Assert.Equal(6, exception.ColumnNumber);
255+
Assert.Equal(8, exception.ColumnNumber);
256256
Assert.Empty(exception.SourceFragment);
257257
}
258258

@@ -332,7 +332,7 @@ public void MappingHostErrorDuringRecursiveExecutionOfFilesIsCorrect()
332332
// Assert
333333
Assert.NotNull(exception);
334334
Assert.Equal("File '" + directoryPath + "/second-file.jsx' not exist.", exception.Message);
335-
}*/
335+
}
336336

337337
#endregion
338338

0 commit comments

Comments
 (0)