Launcher3: Fix potential ConcurrentModificationException

The workspaceItemInfos passed in may be modified elsewhere at the same
time as this executor is running, we can introduce a new ArrayList
object initialized with all original workspaceItemInfos to avoid
ConcurrentModificationException as a tricky workaround.

Bug: 271324475
Test: atest
Change-Id: I087e2b780a35743b8f9cb1371dd13fa241737f8c
Signed-off-by: Pranav Vashi <[email protected]>

Author: shawnlinboy

src/com/android/launcher3/folder/FolderNameProvider.java

@@ -47,6 +47,8 @@
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
+import java.util.function.Function;
+import java.util.function.Predicate;
 import java.util.stream.Collectors;
 
 /**
@@ -110,20 +112,21 @@ public void getSuggestedFolderName(Context context,
             Log.d(TAG, "getSuggestedFolderName:" + nameInfos.toString());
         }
 
+        // A shallow copy tring to avoid ConcurrentModificationException
+        final ArrayList<WorkspaceItemInfo> candidates = new ArrayList<>(workspaceItemInfos);
         // If all the icons are from work profile,
         // Then, suggest "Work" as the folder name
-        Set<UserHandle> users = workspaceItemInfos.stream().map(w -> w.user)
+        Set<UserHandle> users = candidates.stream().map(w -> w.user)
                 .collect(Collectors.toSet());
         if (users.size() == 1 && !users.contains(Process.myUserHandle())) {
             setAsLastSuggestion(nameInfos, getWorkFolderName(context));
         }
 
         // If all the icons are from same package (e.g., main icon, shortcut, shortcut)
         // Then, suggest the package's title as the folder name
-        Set<String> packageNames = workspaceItemInfos.stream()
-                .map(WorkspaceItemInfo::getTargetComponent)
-                .filter(Objects::nonNull)
-                .map(ComponentName::getPackageName)
+        Set<String> packageNames = candidates.stream()
+                .filter(workspaceItemInfo -> workspaceItemInfo.getTargetComponent() != null)
+                .map(workspaceItemInfo -> workspaceItemInfo.getTargetComponent().getPackageName())
                 .collect(Collectors.toSet());
 
         if (packageNames.size() == 1) {