Skip to content

Commit e2c4971

Browse files
committed
[refac] apply code review
1 parent bd1b60c commit e2c4971

File tree

5 files changed

+13
-12
lines changed

5 files changed

+13
-12
lines changed

src/main/java/org/hankki/hankkiserver/api/store/controller/StoreController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ public class StoreController {
2626
private final HeartCommandService heartCommandService;
2727

2828
@GetMapping("/stores/{id}")
29-
public HankkiResponse<StoreGetResponse> getStore(@PathVariable Long id) {
29+
public HankkiResponse<StoreGetResponse> getStore(@PathVariable final Long id) {
3030
return HankkiResponse.success(CommonSuccessCode.OK, storeQueryService.getStoreInformation(id));
3131
}
3232

3333
@GetMapping("/stores/{id}/thumbnail")
34-
public HankkiResponse<StoreThumbnailResponse> getStoreThumbnail(@PathVariable Long id) {
34+
public HankkiResponse<StoreThumbnailResponse> getStoreThumbnail(@PathVariable final Long id) {
3535
return HankkiResponse.success(CommonSuccessCode.OK, storeQueryService.getStoreThumbnail(id));
3636
}
3737

src/main/java/org/hankki/hankkiserver/api/store/service/StoreFinder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ public Store getStoreReference(final Long id) {
1717
return storeRepository.getReferenceById(id);
1818
}
1919

20-
protected Store findByIdWhereDeletedIsFalse(Long id) {
20+
protected Store findByIdWhereDeletedIsFalse(final Long id) {
2121
return storeRepository.findByIdAndIsDeletedIsFalse(id)
2222
.orElseThrow(() -> new NotFoundException(StoreErrorCode.STORE_NOT_FOUND));
2323
}
2424

25-
protected Store findByIdWithHeartAndIsDeletedFalse(Long id) {
25+
protected Store findByIdWithHeartAndIsDeletedFalse(final Long id) {
2626
return storeRepository.findByIdWithHeartAndIsDeletedFalse(id)
2727
.orElseThrow(() -> new NotFoundException(StoreErrorCode.STORE_NOT_FOUND));
2828
}

src/main/java/org/hankki/hankkiserver/api/store/service/StoreQueryService.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.hankki.hankkiserver.api.store.service.response.*;
99
import org.hankki.hankkiserver.domain.store.model.Store;
1010
import org.hankki.hankkiserver.domain.store.model.StoreCategory;
11+
import org.hankki.hankkiserver.domain.store.model.StoreImage;
1112
import org.springframework.stereotype.Service;
1213
import org.springframework.transaction.annotation.Transactional;
1314

@@ -22,12 +23,12 @@ public class StoreQueryService {
2223
private final MenuFinder menuFinder;
2324

2425
@Transactional(readOnly = true)
25-
public StoreThumbnailResponse getStoreThumbnail(Long id) {
26+
public StoreThumbnailResponse getStoreThumbnail(final Long id) {
2627
return StoreThumbnailResponse.of(storeFinder.findByIdWhereDeletedIsFalse(id));
2728
}
2829

2930
@Transactional(readOnly = true)
30-
public StoreGetResponse getStoreInformation(Long id) {
31+
public StoreGetResponse getStoreInformation(final Long id) {
3132

3233
Store store = storeFinder.findByIdWithHeartAndIsDeletedFalse(id);
3334

@@ -55,17 +56,17 @@ public PriceCategoriesResponse getPriceCategories() {
5556
.toList());
5657
}
5758

58-
private List<String> getImageUrlsFromStore(Store store) {
59+
private List<String> getImageUrlsFromStore(final Store store) {
5960
return store.getImages().stream()
60-
.map(storeImage -> storeImage.getImageUrl())
61+
.map(StoreImage::getImageUrl)
6162
.toList();
6263
}
6364

64-
private List<MenuResponse> getMenus(Store store) {
65+
private List<MenuResponse> getMenus(final Store store) {
6566
return menuFinder.findAllByStore(store).stream().map(MenuResponse::of).toList();
6667
}
6768

68-
private boolean isLiked(Long id, Store store) {
69+
private boolean isLiked(final Long id, final Store store) {
6970
return store.getHearts().stream().anyMatch(heart -> heart.getUser().getId().equals(id));
7071
}
7172
}

src/main/java/org/hankki/hankkiserver/api/store/service/response/StoreGetResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public record StoreGetResponse(
1212
List<String> imageUrls,
1313
List<MenuResponse> menus
1414
) {
15-
public static StoreGetResponse of(Store store, boolean isLiked, List<String> imageUrls, List<MenuResponse> menus) {
15+
public static StoreGetResponse of(final Store store, final boolean isLiked, final List<String> imageUrls, final List<MenuResponse> menus) {
1616
return new StoreGetResponse(store.getName(),
1717
store.getCategory().getName(),
1818
store.getHeartCount(),

src/main/java/org/hankki/hankkiserver/api/store/service/response/StoreThumbnailResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public record StoreThumbnailResponse(
99
int lowestPrice,
1010
int heartCount
1111
) {
12-
public static StoreThumbnailResponse of(Store store) {
12+
public static StoreThumbnailResponse of(final Store store) {
1313
return new StoreThumbnailResponse(
1414
store.getId(),
1515
store.getName(),

0 commit comments

Comments
 (0)