From 27be58d6deb33992fe7222ca8ad25f840211a3eb Mon Sep 17 00:00:00 2001 From: fzzyhmstrs <72876796+fzzyhmstrs@users.noreply.github.com> Date: Sat, 21 Sep 2024 11:47:49 -0400 Subject: [PATCH] Remove IconicButtons init removes the init method call that is leaking `this` from iconic$onInitButton --- .../midnightdust/visualoverhaul/mixin/MixinPressableWidget.java | 1 - 1 file changed, 1 deletion(-) diff --git a/common/src/main/java/eu/midnightdust/visualoverhaul/mixin/MixinPressableWidget.java b/common/src/main/java/eu/midnightdust/visualoverhaul/mixin/MixinPressableWidget.java index 1cd4331..e5ab32d 100644 --- a/common/src/main/java/eu/midnightdust/visualoverhaul/mixin/MixinPressableWidget.java +++ b/common/src/main/java/eu/midnightdust/visualoverhaul/mixin/MixinPressableWidget.java @@ -20,7 +20,6 @@ public MixinPressableWidget(int x, int y, int width, int height, Text message) { @Inject(at = @At("TAIL"), method = "") private void iconic$onInitButton(int i, int j, int k, int l, Text text, CallbackInfo ci) { visualoverhaul$iconicButtons = new IconicButtons(); - visualoverhaul$iconicButtons.init(this); } @Inject(at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/widget/PressableWidget;drawMessage(Lnet/minecraft/client/gui/DrawContext;Lnet/minecraft/client/font/TextRenderer;I)V", shift = At.Shift.BEFORE), method = "renderWidget")