refact: extract a TestResultDto factory

Author: Sylvain Fraïssé

pom.xml

@@ -26,6 +26,12 @@
 			<artifactId>commons-io</artifactId>
 			<version>1.3.2</version>
 		</dependency>
+		<dependency>
+			<groupId>org.assertj</groupId>
+			<artifactId>assertj-core</artifactId>
+			<version>3.6.1</version>
+			<scope>test</scope>
+		</dependency>
 	</dependencies>
 
 	<build>

src/main/java/com/codingame/codemachine/runner/junit/TestResultDtoFactory.java

@@ -0,0 +1,47 @@
+package com.codingame.codemachine.runner.junit;
+
+import com.codingame.codemachine.runner.junit.core.RunLogDto;
+import com.codingame.codemachine.runner.junit.core.RunLogStackTraceDto;
+import com.codingame.codemachine.runner.junit.core.TestResultDto;
+import org.junit.runner.Description;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static java.util.Collections.singletonList;
+
+class TestResultDtoFactory {
+    private RunLogDto parseThrowable(Throwable t) {
+        RunLogDto runLog = new RunLogDto();
+        runLog.setMessage(t.getMessage());
+        List<RunLogStackTraceDto> stack = new ArrayList<>();
+        for (StackTraceElement item : t.getStackTrace()) {
+            RunLogStackTraceDto stackItem = new RunLogStackTraceDto();
+            stackItem.setLine(item.getLineNumber());
+            stackItem.setContainer(item.getClassName());
+            stackItem.setFunction(item.getMethodName());
+            stack.add(stackItem);
+        }
+        runLog.setStacktrace(stack);
+
+        if (t.getCause() != null) {
+            runLog.setCause(parseThrowable(t.getCause()));
+        }
+        return runLog;
+    }
+
+    TestResultDto create(boolean success, Description description, Throwable t) {
+        TestResultDto result = new TestResultDto();
+        result.setSuccess(success);
+        result.setNotFound(false);
+        String testReference = description.getClassName();
+        if (description.getMethodName() != null) {
+            testReference += "#" + description.getMethodName();
+        }
+        result.setTestReference(testReference);
+        if (t != null) {
+            result.setLogs(singletonList(parseThrowable(t)));
+        }
+        return result;
+    }
+}

src/test/java/com/codingame/codemachine/runner/junit/TestResultDtoFactoryTest.java

@@ -0,0 +1,58 @@
+package com.codingame.codemachine.runner.junit;
+
+import com.codingame.codemachine.runner.junit.core.RunLogDto;
+import com.codingame.codemachine.runner.junit.core.TestResultDto;
+import org.junit.Test;
+import org.junit.runner.Description;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class TestResultDtoFactoryTest {
+
+    @Test
+    public void should_parse_a_simple_testsuite_success() {
+        String testCase = "com.codingame.test.MyTest";
+        Description testDescription = Description.createSuiteDescription(testCase);
+        TestResultDto testResultDto = new TestResultDtoFactory().create(true, testDescription, null);
+        assertThat(testResultDto.isSuccess()).isTrue();
+        assertThat(testResultDto.isNotFound()).isFalse();
+        assertThat(testResultDto.getTestReference()).isEqualTo(testCase);
+    }
+
+    @Test
+    public void should_parse_a_simple_testcase_success() {
+        String className = "com.codingame.test.MyTest";
+        String test = "theTest";
+        Description testDescription = Description.createTestDescription(className, test);
+        TestResultDto testResultDto = new TestResultDtoFactory().create(true, testDescription, null);
+        assertThat(testResultDto.isSuccess()).isTrue();
+        assertThat(testResultDto.isNotFound()).isFalse();
+        assertThat(testResultDto.getTestReference()).isEqualTo(className + "#" + test);
+    }
+
+    @Test
+    public void should_parse_a_simple_fail() {
+        String testCase = "com.codingame.test.MyTest";
+        Description testDescription = Description.createSuiteDescription(testCase);
+        TestResultDto testResultDto = new TestResultDtoFactory().create(false, testDescription, null);
+        assertThat(testResultDto.isSuccess()).isFalse();
+        assertThat(testResultDto.isNotFound()).isFalse();
+        assertThat(testResultDto.getTestReference()).isEqualTo(testCase);
+    }
+
+    @Test
+    public void should_parse_a_full_fail() {
+        String testCase = "com.codingame.test.MyTest";
+        Description testDescription = Description.createSuiteDescription(testCase);
+        RuntimeException cause = new RuntimeException("Cause");
+        TestResultDto testResultDto =
+            new TestResultDtoFactory().create(false, testDescription, new Throwable("Problem", cause));
+        assertThat(testResultDto.isSuccess()).isFalse();
+        assertThat(testResultDto.isNotFound()).isFalse();
+        assertThat(testResultDto.getTestReference()).isEqualTo(testCase);
+        assertThat(testResultDto.getLogs()).hasSize(1);
+        RunLogDto runLogDto = testResultDto.getLogs().get(0);
+        assertThat(runLogDto.getMessage()).isEqualTo("Problem");
+        assertThat(runLogDto.getCause().getMessage()).isEqualTo("Cause");
+    }
+}