fix(scrollbar): fix scroll background opacity

Author: TomJGooding

src/textual/scrollbar.py

@@ -286,6 +286,8 @@ def render(self) -> RenderableType:
         else:
             background = styles.scrollbar_background
             color = styles.scrollbar_color
+        base_background, _ = self.parent._opacity_background_colors
+        background = base_background + background
         color = background + color
         scrollbar_style = Style.from_color(color.rich_color, background.rich_color)
         if self.screen.styles.scrollbar_color.a == 0:

tests/snapshot_tests/test_snapshots.py

@@ -3251,3 +3251,30 @@ async def run_before(pilot: Pilot) -> None:
         terminal_size=(175, 50),
         run_before=run_before,
     )
+
+
+def test_scrollbar_background_with_opacity(snap_compare):
+    """Regression test for https://github.com/Textualize/textual/issues/5458
+    The scrollbar background should match the background of the widget."""
+
+    class ScrollbarOpacityApp(App):
+        CSS = """
+        Screen {
+            align: center middle;
+        }
+
+        VerticalScroll {
+            width: 50%;
+            height: 50%;
+            background: blue 10%;
+            scrollbar-background: blue 10%;
+            scrollbar-color: cyan;
+            scrollbar-size-vertical: 10;
+        }
+        """
+
+        def compose(self) -> ComposeResult:
+            with VerticalScroll():
+                yield Static("\n".join(f"This is some text {n}" for n in range(100)))
+
+    assert snap_compare(ScrollbarOpacityApp())