Skip to content

.dark mode breaking change #5341

@JoeZiminski

Description

@JoeZiminski

Just a small suggestion, I recently saw that dark mode has been superceeded by themes (which look great BTW). I had some tests that did not pick up the breaking change as the .dark attribute is still held on app vestigially (as far as I can tell). It might be worth either a) setting .dark so it still changes to textual-dark/'light' theme under the hood, or raise deprecation error if it is accessed so this gets flagged in tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions