Crash in App.notify relating to markup

[darrenburns]

If you run the app below and press space, it will crash.

from textual.app import App, ComposeResult
from textual.widgets import Label


class NotifyCrash(App[None]):
    def compose(self) -> ComposeResult:
        yield Label("Press Space to crash!")

    def key_space(self) -> None:
        json = '{"booleans": [true, false]}'
        self.notify(json)


if __name__ == "__main__":
    NotifyCrash().run()

It doesn't crash if I escape markup using textual.markup.escape, like this: self.notify(escape(json)).

Confirmed on Textual 2.1.1 and 1.0.0.

[python-and-novella]

The notify treats [true, false] as markup.

The solution is:

from textual.app import App, ComposeResult
from textual.widgets import Label
from textual.markup import escape

class NotifyCrash(App[None]):
    def compose(self) -> ComposeResult:
        yield Label("Press Space to crash!")

    def key_space(self) -> None:
        json = '{"booleans": [true, false]}'
        self.notify(escape(json))


if __name__ == "__main__":
    NotifyCrash().run()

BTW, notify's parameter message can parse markup, but the '[red]hello' works well, the '[#ff0]hello' raises error.

from textual.app import App

class MyApp(App):
    def key_q(self):
        self.notify(message='[red]hello')
    def key_w(self):
        self.notify(message='[#ff0]hello')

if __name__ == '__main__':
    app = MyApp()
    app.run()