Align doesn't work with height and min-height combination in widget

[matkudela]

This example shows that align property is not working well. Static widget should be positioned vertically in the middle of CustomWidget. It was broken between 0.83.0 version and 2.1.2.

from __future__ import annotations

from textual.app import App, ComposeResult
from textual.widget import Widget
from textual.widgets import Footer, Static


class CustomWidget(Widget):
    DEFAULT_CSS = """
    CustomWidget {
      width: 1fr;
      background: grey;
      height: auto;
      min-height: 3;
      align: center middle; /* align doesn't work with height and min-height combination */
      
      Static {
        background: red;
      }
    }
    """

class MyApp(App):
    def compose(self) -> ComposeResult:
        with CustomWidget():
            yield Static("Some text")
        yield Footer()


MyApp().run()

With deleted min-height and static height: 3 static widget is positioned properly:

from __future__ import annotations

from textual.app import App, ComposeResult
from textual.widget import Widget
from textual.widgets import Footer, Static


class CustomWidget(Widget):
    DEFAULT_CSS = """
    CustomWidget {
      width: 1fr;
      background: grey;
      height: 3;
      align: center middle; /* now align works properly */
      
      Static {
        background: red;
      }
    }
    """

class MyApp(App):
    def compose(self) -> ComposeResult:
        with CustomWidget():
            yield Static("Some text")
        yield Footer()


MyApp().run()

[github-actions]

We found the following entries in the FAQ which you may find helpful:

• Why do some key combinations never make it to my app?
• How do I center a widget in a screen?

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

[TomJGooding]

This issue with auto containers with auto children is proving tricky! The container size seems correct in the latest version at least, hopefully just the alignment need ironing out...

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.