From 6af743d426eb286c2bc18a42887eb71b5e87bd24 Mon Sep 17 00:00:00 2001
From: TomJGooding <101601846+TomJGooding@users.noreply.github.com>
Date: Fri, 7 Feb 2025 16:03:16 +0000
Subject: [PATCH] ci: update artifact action

Fix failing workflow by updating artifact action to v4 (v3 is deprecated):

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

There are key differences from the previous version, where artifacts are
now immutable. Hopefully I've understood correctly that the artifact
should be overwritten?

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
---
 .github/workflows/pythonpackage.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml
index 9df7cf2fbf..ce1a8efa65 100644
--- a/.github/workflows/pythonpackage.yml
+++ b/.github/workflows/pythonpackage.yml
@@ -49,7 +49,8 @@ jobs:
         if: ${{ matrix.python-version == '3.8' }}
       - name: Upload snapshot report
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: snapshot-report-textual
           path: snapshot_report.html
+          overwrite: true