Skip to content

Highlighter IsSetUp is only true #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
jimbosquash opened this issue Jan 14, 2025 · 0 comments · May be fixed by #542
Closed
5 tasks done

Highlighter IsSetUp is only true #556

jimbosquash opened this issue Jan 14, 2025 · 0 comments · May be fixed by #542
Labels
bug Something isn't working

Comments

@jimbosquash
Copy link

jimbosquash commented Jan 14, 2025

Describe the bug 📝

I am using next.js to change pages. when i leave the viewer page i want to disconnect the highlighter and reconnect. I have tried disposing but the isSetup toggle remains true due to that being its default state. when disposing could you make it toggle isSetup to false? Or is there another way to destroy components like highlighter that I should consider? I want to in general keep my obc.components and custom component instances when I page change instead of killing the components instance and rebuild.

the outcome is that i am unable to hook up the event listeners again to the dom object that is created a new when I page change

Reproduction ▶️

No response

Steps to reproduce 🔢

No response

System Info 💻

System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 751.36 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.18.1 - ~/Documents/Local_Repository/nextjs-with-supabase/node_modules/.bin/node
    npm: 10.9.0 - /usr/local/bin/npm
    pnpm: 9.13.2 - /usr/local/bin/pnpm
  Browsers:
    Brave Browser: 130.1.71.123
    Chrome: 131.0.6778.265
    Safari: 17.4.1

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@jimbosquash jimbosquash added the bug Something isn't working label Jan 14, 2025
GoulielmosFloros added a commit to GoulielmosFloros/engine_components that referenced this issue Mar 8, 2025
Added isSetup equals to false for the async function when you dispose the highlighter. Therefore if whenever you specify highlighter.dispose() every time you switch pages the isSetup becomes false.

Reviewed-by: Goulielmos Floros
Ref: ThatOpen#556
GoulielmosFloros added a commit to GoulielmosFloros/engine_components that referenced this issue Mar 18, 2025
Added isSetup equals to false for the async function when you dispose the highlighter. Therefore if whenever you specify highlighter.dispose() every time you switch pages the isSetup becomes false.

Reviewed-by: Goulielmos Floros
Ref: ThatOpen#556
HoyosJuan pushed a commit that referenced this issue Apr 1, 2025
Added isSetup equals to false for the async function when you dispose the highlighter. Therefore if whenever you specify highlighter.dispose() every time you switch pages the isSetup becomes false.

Reviewed-by: Goulielmos Floros
Ref: #556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants