Merge pull request #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @Kaushkiraj looks good to me. Try squashing your commits into one. Read this |
adiaholic
requested changes
Jun 16, 2020
Member
adiaholic
left a comment
adiaholic
left a comment
There was a problem hiding this comment.
There are 2 things you need to take care of:
- Never use your master branch to push features. Instead you should make a branch on your fork: eg kaushikiraj/some-relevant-name. If you make PRs from the master branch, you won't be able to work on multiple issues simultaneously.
- The PR message
Merge pull requestdoesn't carry any significant information. It is in best practise to write something which gives the reviewer a gist of what that PR does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first time, I am contributing to open source. Thanks a lot to all the member of Codesis.