Skip to content

Commit 9d93e98

Browse files
authored
Merge pull request #66 from sentenza/9-readme-and-updates
Add missing docs and upgrade dependencies
2 parents cf0fef3 + 887a980 commit 9d93e98

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+740
-363
lines changed

Diff for: .gitignore

+49-9
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,56 @@
1-
# dotenv
2-
.env
1+
## sbt
2+
logs
3+
target
4+
/.idea
5+
/.idea_modules
6+
/.classpath
7+
/.gradle
8+
/.project
9+
/.gradle
10+
/.settings
11+
/public/*
312

4-
# virtualenv
5-
venv/
6-
ENV/
13+
# sbt specific
14+
.cache
15+
.history
16+
.lib/
17+
.bsp/
18+
dist/*
19+
lib_managed/
20+
src_managed/
21+
project/boot/
722

8-
# Rope project settings
23+
# Scala-IDE specific
24+
.scala_dependencies
25+
.worksheet
926
.ropeproject
1027
.idea
28+
29+
# Temporary
30+
.netrwhist
31+
*~
32+
33+
# Vim specific ---
34+
# Swap
35+
[._]*.s[a-v][a-z]
36+
[._]*.sw[a-p]
37+
[._]s[a-v][a-z]
38+
[._]sw[a-p]
39+
._*
40+
*.swp
41+
*.swo
42+
43+
# System Files
1144
.DS_Store
45+
Thumbs.db%
1246

47+
## Metals
48+
.metals
49+
.bloop
1350

14-
# sbt specific
15-
target/
16-
project/target
51+
# dotenv
52+
.env
53+
54+
# virtualenv
55+
venv/
56+
ENV/

Diff for: .scalafmt.conf

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
version = "3.0.6"
2+
3+
runner.dialect = scala213source3
4+
align.preset = more
5+
style = defaultWithAlign
6+
maxColumn = 115
7+
docstrings.style = SpaceAsterisk
8+
docstrings.removeEmpty = true
9+
continuationIndent.callSite = 2
10+
continuationIndent.defnSite = 4
11+
includeCurlyBraceInSelectChains = false
12+
project.git = true
13+
project.excludeFilters = ["target/"]

Diff for: .travis.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
os: linux
33
dist: xenial
44
language: scala
5-
scala: 2.13.3
5+
scala:
6+
- 2.13.6
67
jdk:
7-
- openjdk8
8-
# - openjdk11 # Fails!
8+
- openjdk11
99
# - openjdk14 # Fails!
1010
# - openjdk15 # Fails!

Diff for: CONTRIBUTING.md

+62
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
## How to contribute?
2+
3+
#### Did you find a bug?
4+
5+
* **Ensure the bug was not already reported** by searching on GitHub
6+
under [Project Issues](https://github.com/TheAlgorithms/Scala/issues).
7+
* Please avoid opening issues asking to be "assigned" to a particular algorithm. This merely creates unnecessary noise
8+
for maintainers. Instead, please submit your implementation in a pull request, and it will be evaluated by project
9+
maintainers.
10+
* If you are unable to find an open issue referring to the same problem, depending on the type of issue follow the
11+
appropriate steps:
12+
13+
#### Do you want to contribute to the documentation?
14+
15+
- Please read the documentation in
16+
here [Contributing to the Documentation](https://github.com/TheAlgorithms/Scala/blob/master/CONTRIBUTING.md),
17+
[open a new one issue](https://github.com/TheAlgorithms/Scala/issues/new), make changes and then create a pull
18+
request, it will be put under review and accepted if it is appropriate.
19+
20+
#### Do you want to add a new feature?
21+
22+
* [Open a new one issue](https://github.com/TheAlgorithms/Scala/issues/new). Be sure to include a **title and a clear
23+
description** and a **test case** demonstrating the new feature that you want to add to the project.
24+
25+
##### Contributing to Algorithms (Make sure to check all the points below before opening a PR)
26+
27+
* Make sure you follow proper coding standards and naming conventions.
28+
* Please
29+
use [Binary Search Implementation](https://github.com/TheAlgorithms/Scala/blob/master/src/main/scala/Search/BinarySearch.scala)
30+
*
31+
and [Binary Search Test](https://github.com/TheAlgorithms/Scala/blob/master/src/test/scala/Search/BinarySearchSpec.scala)
32+
as a reference.
33+
* Add the algorithm implementation as an object and not as a class
34+
* Add proper comments about the algorithm implementation and the functions present in the algorithm
35+
* Add a test spec in the test folder under the same domain as that of your algorithm. **PRs without a test spec would
36+
not be accepted!**
37+
* Add at least 1 positive and 1 negative test in the test spec
38+
* Raise a PR for the algorithm object file and the test spec
39+
* [How to write a test case in Scala](http://www.scalatest.org/user_guide/writing_your_first_test)
40+
41+
#### Contributing to Tests
42+
43+
* You can contribute tests for a specific algorithm
44+
* Add as many tests as you can and try to cover all the borderline test cases
45+
* Open a PR with for your testSpec
46+
* Make sure you are not adding redundant test cases
47+
* If you see that the algorithm fails for a particular test case, then open an issue with proper explanation.
48+
* [How to write a test case in Scala](http://www.scalatest.org/user_guide/writing_your_first_test)
49+
50+
#### Do you want to fix a bug?
51+
52+
* [Open a new issue](https://github.com/TheAlgorithms/Scala/issues/new).Be sure to include a **title and a clear
53+
description** and a **test case** demonstrating the expected behaviour that is not occurring.
54+
55+
#### **Do you have questions about the source code?**
56+
57+
* Ask any question about how to use the repository in
58+
the [TheAlgorithms room in GITTER](https://gitter.im/TheAlgorithms/community?source=orgpage#) or
59+
[open a new one issue](https://github.com/TheAlgorithms/Scala/issues/new)
60+
61+
:+1::tada: That's all you need to know about the process now it's your turn to help us improve the repository, thank you
62+
again! :+1::tada:

0 commit comments

Comments
 (0)