Refactor NetworkContext to include environment direction

Added an environment direction field to NetworkContext and updated relevant methods across various networking implementations to use it. This change improves the clarity and specificity of network context handling, differentiating between client and server environments. Updated CHANGELOG to reflect these modifications.

Author: ThePandaOliver

CHANGELOG.md

@@ -1,15 +1,21 @@
-# Changelog 0.5 Beta
+# Version 0.5 Beta
+
+## User Changelog
+It seems like there is nothing new.
 
-## Config API
-* Converting json elements into nbt tags when sending them over via packets
 
-## Technical changes
-* Restructured the whole project
+## Developer Changelog
+### Networking API
+* Added a new event `NetworkingEvents$PACKET_PAYLOAD_REGISTRY` for registering packets
+* Added `PacketDistributor` class for sending packets to players and server.
 
-## License Update
-* Reverted license to GNU LGPLv3 (previously GNU GPLv3)
+### Config API
+* Converting json elements into nbt tags when sending them over via packets
 
-## Developer Info
+### Notes
 * Replaced the old config codecs with a new `ConfigCodec` class
 * Added a new util class `NBTUtils` which contains conversion functions for converting between nbt tags and gson json elements
-* Renamed the `MathUtils` methods `rotateByPivot` to `rotateAroundOrigin` 
+* Renamed the `MathUtils` methods `rotateByPivot` to `rotateAroundOrigin`
+
+### License Update
+* Reverted license to GNU LGPLv3 (previously GNU GPLv3)

common/src/main/java/me/pandamods/pandalib/networking/NetworkContext.java

@@ -12,22 +12,26 @@
 
 package me.pandamods.pandalib.networking;
 
-import dev.architectury.platform.Platform;
 import dev.architectury.utils.Env;
 import net.minecraft.world.entity.player.Player;
 
 public class NetworkContext {
 	private final Player player;
+	private final Env envDirection;
 
-	public NetworkContext(Player player) {
+	public NetworkContext(Player player, Env envDirection) {
 		this.player = player;
+		this.envDirection = envDirection;
 	}
 
 	public Player getPlayer() {
 		return player;
 	}
 
-	public Env getEnvironment() {
-		return Platform.getEnvironment();
+	/**
+	 * @return the environment direction the packet was send.
+	 */
+	public Env getDirection() {
+		return envDirection;
 	}
 }

fabric/src/main/java/me/pandamods/pandalib/fabric/networking/NetworkingRegistryImpl.java

@@ -47,7 +47,7 @@ private static class ClientPlayPayloadHandler<T extends CustomPacketPayload> imp
 
 		@Override
 		public void receive(T payload, ClientPlayNetworking.Context context) {
-			NetworkContext networkContext = new NetworkContext(context.player());
+			NetworkContext networkContext = new NetworkContext(context.player(), Env.CLIENT);
 			receiver.receive(networkContext, payload);
 		}
 	}
@@ -57,7 +57,7 @@ public <T extends CustomPacketPayload> void registerServerReceiver(CustomPacketP
 																	   StreamCodec<? super RegistryFriendlyByteBuf, T> codec,
 																	   NetworkReceiver<T> receiver) {
 		PayloadTypeRegistry.playC2S().register(type, codec);
-		ServerPlayNetworking.registerGlobalReceiver(type, (t, context) -> receiver.receive(new NetworkContext(context.player()), t));
+		ServerPlayNetworking.registerGlobalReceiver(type, (t, context) -> receiver.receive(new NetworkContext(context.player(), Env.SERVER), t));
 	}
 
 	@Override

neoforge/src/main/java/me/pandamods/pandalib/neoforge/networking/NetworkingRegistryImpl.java

@@ -13,6 +13,7 @@
 package me.pandamods.pandalib.neoforge.networking;
 
 import dev.architectury.platform.Platform;
+import dev.architectury.utils.Env;
 import me.pandamods.pandalib.event.events.NetworkingEvents;
 import me.pandamods.pandalib.networking.NetworkContext;
 import me.pandamods.pandalib.networking.NetworkReceiver;
@@ -34,14 +35,14 @@ public NetworkingRegistryImpl() {
 	public <T extends CustomPacketPayload> void registerClientReceiver(CustomPacketPayload.Type<T> type,
 																	   StreamCodec<? super RegistryFriendlyByteBuf, T> codec,
 																	   NetworkReceiver<T> receiver) {
-		this.playToClient(type, codec, (arg, ctx) -> receiver.receive(new NetworkContext(ctx.player()), arg));
+		this.playToClient(type, codec, (arg, ctx) -> receiver.receive(new NetworkContext(ctx.player(), Env.CLIENT), arg));
 	}
 
 	@Override
 	public <T extends CustomPacketPayload> void registerServerReceiver(CustomPacketPayload.Type<T> type,
 																	   StreamCodec<? super RegistryFriendlyByteBuf, T> codec,
 																	   NetworkReceiver<T> receiver) {
-		this.playToServer(type, codec, (arg, ctx) -> receiver.receive(new NetworkContext(ctx.player()), arg));
+		this.playToServer(type, codec, (arg, ctx) -> receiver.receive(new NetworkContext(ctx.player(), Env.SERVER), arg));
 	}
 
 	@Override
@@ -50,8 +51,8 @@ public <T extends CustomPacketPayload> void registerBiDirectionalReceiver(Custom
 																			  NetworkReceiver<T> clientReceiver,
 																			  NetworkReceiver<T> serverReceiver) {
 		this.playBidirectional(type, codec, new DirectionalPayloadHandler<>(
-				(arg, ctx) -> clientReceiver.receive(new NetworkContext(ctx.player()), arg),
-				(arg, ctx) -> serverReceiver.receive(new NetworkContext(ctx.player()), arg)
+				(arg, ctx) -> clientReceiver.receive(new NetworkContext(ctx.player(), Env.CLIENT), arg),
+				(arg, ctx) -> serverReceiver.receive(new NetworkContext(ctx.player(), Env.SERVER), arg)
 		));
 	}