Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dangling pointer in TheThingsMessage #257

Open
paulbendixen opened this issue Jun 25, 2019 · 1 comment
Open

Dangling pointer in TheThingsMessage #257

paulbendixen opened this issue Jun 25, 2019 · 1 comment

Comments

@paulbendixen
Copy link

When calling TheThingsMessage::encodeDeviceData, the buffer pointer pointer gets set to a temporary array on the stack, this might happen to work in most cases, but if anything is called between encoding and sending, this might break horribly and is at least undefined behaviour.
@johanstokking
Copy link
Member

Thanks for pointing out. Can you file a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulbendixen @johanstokking