Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minify all enqueued scripts and styles #58

Open
middlesister opened this issue Sep 14, 2013 · 3 comments
Open

minify all enqueued scripts and styles #58

middlesister opened this issue Sep 14, 2013 · 3 comments

Comments

@middlesister
Copy link
Member

Keep original for reference and enqueue the minified.

file.css       <---- with plenty of comments
file.min.css   <------ enqueued file
@scottnix
Copy link
Contributor

I would almost say to push this issue way down on the list of features to implement.

For anyone using Sass, this isn't useful. An extra few steps would most likely need to be added to Sass to get it to save the file name with the .min. portion of the file extension.

Also I hope most people use a WordPress Plugin like W3 Total Cache which does minify, so it may be unnecessary to worry about this too much.

@JamesGeiger
Copy link
Contributor

Still a good idea though to minify it.

@middlesister
Copy link
Member Author

Yes minifying will definitely be something done towards the end of the release cycle. But I like it because

a) It might discourage tampering with the parent css file and promote proper use of a child theme and b) I want to make the parent theme as small and fast as possible.

I agree that the best option for many sites is a plugin like W3 total cache, but it doesn't hurt to have the parent theme defaults with best performance in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants