-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0 release checklist #95
Comments
@middlesister There are still some styling issues. I will send you a fix for those tonight. @scottnix, if you are still alive can you take a look at the new stylesheet if you get a chance? |
Oh, yes I know. Above all - we have three pull requests waiting for feedback from gene. I am not ready to release anything until he gets a say. He is also the one who has the contact with Ian, and Ian is the only one with access to upload to the wordpress.org repo. |
@middlesister I was too tired to look last night, but I will send a pull request in a day or two. Can't you be made the owner of Thematic on wordpress.org? It is kind of silly that Ian has to submit it since he has not worked on it in years. |
I have the newest development version setup locally, I will take a look some time today. I will try to test some crossbrowser stuff and check everything out, especially the portions dealing with responsive design. :) |
@scottnix cool. I can sleep easier if you look at it lol |
@SeamlessThemes I know, it's a little frustrating. This is how it's been all these years. Every time a new version is ready we have to send it to Ian for submission. Access to the svn is tied to the .org account that created it. It is possible to change, but it is apparently not trivial and to convince Otto to do it would not be easy. Besides, if anyone should have that authority it should be Gene and not me. But the reality is that this is Ian's creation and he still has the last word on the project. Which I understand, his name is on it. I too would like to have a say in something that bears my name. @scottnix oh yes please do! I think the side margins probably should be bigger on tablets/medium screens, but it really is not my strength. I did follow the practice of putting the media queries in the section they apply to instead of in one chunk in the bottom. I like it, I just hope it doesn't become too confusing to read and override. |
@middlesister well it might be his, but it is only what it is today because of the community. Also no offense to Gene, but he just disappeared too. It is a volunteer project, but you should at least announce that you are taking a break or something like that. Just my 2 cents. |
Well you could as well say that I disappeared all summer and autumn too. We all work on it when we have time, it's just not always that our schedules match. The whole legacy mode structure is his work and without it we couldn't be where we are today. Backwards compatibility is crucial, especially with such a large install base that Thematic has. |
@middlesister yes I know he did a lot and I was not trying to put him down, but hey, sometimes you need to point some fingers :D |
Heh, well I would like to hear from him too so there we agree. :) I have pinged him and am waiting for response. He was working 6-7 days a week in the end of November so I can only hope he has less of a workload now and can spare a moment for Thematic. |
@middlesister can we retired the grids folder? I really doubt anyone uses it anymore. |
@scottnix did you get a chance to look? |
I am a little confused, it doesn't help that I haven't done anything really Thematic related for a while now. Is style1.css loading as kind of a test for development? With style1.css loading that way it will break every existing theme out there if they upgrade, which is why I hope it is a testing thing. ;P
|
@middlesister .page-title needs to be made bigger, right now it is extremely small. |
@scottnix Thanks for your list and for checking! I will add these to issue #61 since this is not the place. I realize I have not been consistent in referencing the issue number in my commit messages because if I had, all style related commits would be listed in that issue. Some of these things were already on my list and even fixed very recently. Regarding the stylesheet, no it's not a testing thing. This stylesheet will be used by default on all new installs. This is the beauty of the dependency filter. In xhtml mode - and all upgraded themes will be in xhtml mode by default - the dependency is removed so this stylesheet will never be enqueued. This filter lives in legacy/legacy.php. The whole file is basically an inverse of my html5 plugin and then some. It will turn almost everything back to the way it was in 1.0.4 with very few exceptions. I tested an upgrade using a github upgrader plugin, and this worked. The old child theme did not break. For upgrades, the switch to html5 will need to be done manually by checking a check box in the theme options. This way, it's a conscious decision and can be done after or while updating the child theme. One of my biggest tasks is actually writing a transition guide for the docs section, outlining all the changes needed. @SeamlessThemes yes this is addressed in e819e06 |
Any idea on when the 2.0 will be released? |
Not at the moment, no :( |
@alessandroweb Thematic 2.0-beta1 is now tagged and ready for download. Download link is https://github.com/ThematicTheme/Thematic/archive/2.0-beta1.zip |
@middlesister @emhr Any new on Thematic 2.0 going live?? |
Any news? |
The text was updated successfully, but these errors were encountered: