Skip to content

Commit

Permalink
Skip faketime tests on macOS (#2154)
Browse files Browse the repository at this point in the history
This PR fixes the issue we are experiencing with macOS 13 runners when running tests that require faketime (invalid instruction error). Disable faketime tests on macOS until this can be resolved.

Log: https://gist.github.com/kounelisagis/d88c23c65e1198556f0493e45c357e4c

[sc-63017]
  • Loading branch information
kounelisagis authored Feb 6, 2025
1 parent 9e84b57 commit 39f8697
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ jobs:
os:
- ubuntu-latest
- macos-13
# libfaketime tests fail on macos arm. Disable tests for now.
# - macos-14
- macos-14
- windows-latest
python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]
fail-fast: false
Expand Down Expand Up @@ -66,8 +65,8 @@ jobs:
run: brew install pkg-config
if: startsWith(matrix.os, 'macos')

- name: "Install libfaketime (linux and macOS)"
if: ${{ ! startsWith(matrix.os, 'windows') }}
- name: "Install libfaketime (Linux only)"
if: ${{ startsWith(matrix.os, 'ubuntu') }}
run: |
git clone https://github.com/wolfcw/libfaketime/
cd libfaketime
Expand Down
4 changes: 2 additions & 2 deletions tiledb/tests/test_timestamp_overrides.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def has_libfaketime():


@pytest.mark.skipif(
sys.platform == "win32" or not has_libfaketime(),
reason=f"libfaketime not installed. {'Not supported on Windows.' if sys.platform == 'win32' else ''}",
sys.platform != "linux2" or not has_libfaketime(),
reason=f"This test is only supported on Linux with libfaketime installed.",
)
class TestTimestampOverrides(DiskTestCase):
def test_timestamp_overrides(self):
Expand Down

0 comments on commit 39f8697

Please sign in to comment.