Skip to content

Commit 39f8697

Browse files
authored
Skip faketime tests on macOS (#2154)
This PR fixes the issue we are experiencing with macOS 13 runners when running tests that require faketime (invalid instruction error). Disable faketime tests on macOS until this can be resolved. Log: https://gist.github.com/kounelisagis/d88c23c65e1198556f0493e45c357e4c [sc-63017]
1 parent 9e84b57 commit 39f8697

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ jobs:
2222
os:
2323
- ubuntu-latest
2424
- macos-13
25-
# libfaketime tests fail on macos arm. Disable tests for now.
26-
# - macos-14
25+
- macos-14
2726
- windows-latest
2827
python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]
2928
fail-fast: false
@@ -66,8 +65,8 @@ jobs:
6665
run: brew install pkg-config
6766
if: startsWith(matrix.os, 'macos')
6867

69-
- name: "Install libfaketime (linux and macOS)"
70-
if: ${{ ! startsWith(matrix.os, 'windows') }}
68+
- name: "Install libfaketime (Linux only)"
69+
if: ${{ startsWith(matrix.os, 'ubuntu') }}
7170
run: |
7271
git clone https://github.com/wolfcw/libfaketime/
7372
cd libfaketime

tiledb/tests/test_timestamp_overrides.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ def has_libfaketime():
2020

2121

2222
@pytest.mark.skipif(
23-
sys.platform == "win32" or not has_libfaketime(),
24-
reason=f"libfaketime not installed. {'Not supported on Windows.' if sys.platform == 'win32' else ''}",
23+
sys.platform != "linux2" or not has_libfaketime(),
24+
reason=f"This test is only supported on Linux with libfaketime installed.",
2525
)
2626
class TestTimestampOverrides(DiskTestCase):
2727
def test_timestamp_overrides(self):

0 commit comments

Comments
 (0)