Skip to content

Commit 610fd32

Browse files
authored
Increase test_memory_cleanup target ratio (#2131)
(fix local failure on macos-arm64) This is a very crude memory cleanup test which runs queries in a loop, and compares the starting and ending RSS to catch large leaks. It fails at the current 2x ratio on macos-arm64. Increase the ratio to 2.5. To confirm that this is not masking an arch-specific leak, I ran 10x iterations of the target function. - `final / initial` RSS for 100 runs vs 1000 runs in the `use_many_buffers` loop: ``` (Pdb) 1029292032 / 431456256 2.3856231487810433 (Pdb) p 1023819776 / 427802624 2.393205928535866 ```
1 parent 40b6880 commit 610fd32

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tiledb/tests/test_libtiledb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3385,7 +3385,7 @@ def test_memory_cleanup(self, capfd):
33853385
print(" final RSS after forced GC: {}".format(round(final_gc / 1e6, 2)))
33863386

33873387
assert_captured(capfd, "final RSS")
3388-
self.assertTrue(final < (2 * initial))
3388+
self.assertTrue(final < (2.5 * initial))
33893389

33903390

33913391
class TestHighlevel(DiskTestCase):

0 commit comments

Comments
 (0)