Skip to content

Commit 0a97612

Browse files
committed
Fix ASAN: Destructors of base classes must be virtual
1 parent d391375 commit 0a97612

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tiledb/sm/query/readers/result_tile.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ class ResultTile {
466466
DISABLE_COPY_AND_COPY_ASSIGN(ResultTile);
467467
DISABLE_MOVE_AND_MOVE_ASSIGN(ResultTile);
468468

469-
/** Default destructor. */
469+
/** Destructor needs to be virtual, this is a base class. */
470470
virtual ~ResultTile();
471471

472472
/* ********************************* */
@@ -931,6 +931,9 @@ class ResultTileWithBitmap : public ResultTile {
931931
DISABLE_COPY_AND_COPY_ASSIGN(ResultTileWithBitmap);
932932
DISABLE_MOVE_AND_MOVE_ASSIGN(ResultTileWithBitmap);
933933

934+
/** Default destructor needs to be virtual, this is a base class. */
935+
virtual ~ResultTileWithBitmap() = default;
936+
934937
public:
935938
/* ********************************* */
936939
/* PUBLIC METHODS */

0 commit comments

Comments
 (0)