Address some PR feedback.

Author: teo-tsirpanis

tiledb/sm/fragment/fragment_metadata.h

@@ -791,7 +791,7 @@ class FragmentMetadata {
   URI validity_uri(const std::string& name) const;
 
   /** Return the array schema name. */
-  const std::string& array_schema_name() const {
+  inline const std::string& array_schema_name() const {
     return array_schema_name_;
   }
 
@@ -1122,7 +1122,7 @@ class FragmentMetadata {
    *
    * @return
    */
-  const shared_ptr<const ArraySchema>& array_schema() const {
+  inline const shared_ptr<const ArraySchema>& array_schema() const {
     return array_schema_;
   }
 

tiledb/sm/query/strategy_base.cc

@@ -38,7 +38,6 @@
 #include "tiledb/sm/misc/tdb_time.h"
 #include "tiledb/sm/query/query_buffer.h"
 #include "tiledb/sm/storage_manager/context_resources.h"
-#include "tiledb/sm/storage_manager/storage_manager.h"
 
 namespace tiledb {
 namespace sm {
@@ -64,10 +63,6 @@ StrategyBase::StrategyBase(
     , offsets_bitsize_(constants::cell_var_offset_size * 8) {
 }
 
-ContextResources& StrategyBase::resources() const {
-  return storage_manager_->resources();
-}
-
 void StrategyBase::set_stats(const stats::StatsData& data) {
   stats_->populate_with_data(data);
 }

tiledb/sm/query/strategy_base.h

@@ -39,7 +39,7 @@
 #include "tiledb/sm/array_schema/dimension.h"
 #include "tiledb/sm/misc/types.h"
 #include "tiledb/sm/storage_manager/context_resources.h"
-#include "tiledb/sm/storage_manager/storage_manager_declaration.h"
+#include "tiledb/sm/storage_manager/storage_manager.h"
 
 namespace tiledb {
 namespace sm {
@@ -208,7 +208,9 @@ class StrategyBase {
   /* ********************************* */
 
   /** Returns the context resources of the writer. */
-  ContextResources& resources() const;
+  inline ContextResources& resources() const {
+    return storage_manager_->resources();
+  }
 
   /** Returns `stats_`. */
   inline stats::Stats* stats() const {