Set all uris in one place

Author: ypatia

tiledb/sm/group/group.cc

@@ -320,6 +320,7 @@ const shared_ptr<GroupDetails> Group::group_details() const {
 void Group::set_uri(const URI& uri) {
   std::lock_guard<std::mutex> lck(mtx_);
   group_uri_ = uri;
+  group_details_->set_group_uri(uri);
 }
 
 QueryType Group::get_query_type() const {

tiledb/sm/group/group_details.cc

@@ -36,6 +36,7 @@
 #include "tiledb/sm/enums/datatype.h"
 #include "tiledb/sm/enums/encryption_type.h"
 #include "tiledb/sm/enums/query_type.h"
+#include "tiledb/sm/filesystem/uri.h"
 #include "tiledb/sm/global_state/unit_test_config.h"
 #include "tiledb/sm/group/group_details_v1.h"
 #include "tiledb/sm/group/group_details_v2.h"
@@ -260,9 +261,9 @@ const URI& GroupDetails::group_uri() const {
   return group_uri_;
 }
 
-void GroupDetails::set_group_uri(const std::string& uri) {
+void GroupDetails::set_group_uri(const URI& uri) {
   std::lock_guard<std::mutex> lck(mtx_);
-  group_uri_ = URI(uri);
+  group_uri_ = uri;
 }
 
 uint64_t GroupDetails::member_count() const {

tiledb/sm/group/group_details.h

@@ -185,7 +185,7 @@ class GroupDetails {
   const URI& group_uri() const;
 
   /** Sets the group URI. */
-  void set_group_uri(const std::string& uri);
+  void set_group_uri(const URI& uri);
 
   /**
    * Get count of members

tiledb/sm/serialization/group.cc

@@ -187,7 +187,6 @@ Status group_details_from_capnp(
   if (group_details_reader.hasLogicalURI()) {
     const char* logical_uri = group_details_reader.getLogicalURI().cStr();
     group->set_uri(URI(logical_uri));
-    group->group_details()->set_group_uri(logical_uri);
   }
 
   group->group_details()->set_modified();