-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x release #40
Comments
I've been working a little bit more with your component now. It's really awesome! |
Small announcement: I have just released Chonky You can find it here: https://chonky.io/ |
Awesome work! What wasn't clear to me was how do I drag a file that is present inside a Folder out of it. Basically the opposite of dragging and dropping a file in a folder. |
Great job, thanks a lot. |
Thanks @TheAksh! Moving files to the parent directory using drag & drop is not supported yet, but I'm planning to work on this soon. I'll use the mechanism suggested in #42. Thanks @AndreyVanyakin, it's an interesting question! I think Recoil is a great library and I definitely enjoyed using it. The main pitfall in my opinion is that it is still experimental - it's not very stable (as you might have seen from many console errors in Chonky 1.x), and the developers are keen on using experimental React features which forces library users to upgrade to the most recent version of React. They are doing some cool things under the hood so it's understandable, but I didn't want to force people to upgrade just because Chonky uses Recoil under the hood. Recoil's experimental status was a nuisance but it was not the main driver for switching to Redux. I'd say there were 3 reasons for switching (in the descending order of importance):
In conclusion, I will repeat that I really enjoyed using Recoil and will definitely use it again in some smaller component libraries. There is virtually zero boilerplate in Recoil, but nowadays Redux boilerplate is not that annoying either (thanks Redux Toolkit!). I also wouldn't be surprised if over time Recoil would introduce more Redux-like features (or vice versa) to become the greatest state management library ever built. P.S. I unknowingly re-invented |
Thanks for such a detailed response. |
Created an issue on the exact-trie that you own. Commenting it here, since that is a dependency of this library. As an Amazonian, you'd know the InfoSec restrictions considering the Licenses used. 😁 |
Good catch @TheAksh! I have fixed the license issue and published a new version of Chonky (actually did that a few days ago, but forgot to comment, sorry!). |
No probs! Yes noticed that..thank you for the prompt change! |
@TimboKZ any thoughts on localization? |
@rhummelmose I think it would be nice to have, just need to get around to adding it. I can't say it's at the top of my priority list though. Do you need to translate Chonky into a specific language? |
Yes, for an admin panel though, so it isn't mission critical :) |
@rhummelmose I see. Have you done this with any other React libraries? Do you know if there are any good examples to follow? |
@TimboKZ Is there any update on the |
@dragosrotaru does solution described on https://chonky.io/docs/2.x/basics/drag-n-drop#cannot-have-two-html5-backends not work for you? |
@TimboKZ Ah I am sorry, I should have read the documentation more carefully. Thank you for your help and for making chonky! |
how can we change css can get any reference link please |
@TimboKZ , the library is awesome.. But getting a CSS issue.. The CSS for the folders and files is not getting loaded... Attaching a screenshot.. Can you please have an option to add the css file separately so that a developer can change the CSS properties on demand. |
Everything looks great with this package but I think it's time to update it to a newer material-ui, is this still being maintained? @TimboKZ thanks! |
Bumps [@mui/styles](https://github.com/mui/material-ui/tree/HEAD/packages/mui-styles) from 5.11.9 to 5.11.11. - [Release notes](https://github.com/mui/material-ui/releases) - [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui/material-ui/commits/v5.11.11/packages/mui-styles) --- updated-dependencies: - dependency-name: "@mui/styles" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This working perfectly now (I have tested it both on react js and next js). Sorry for the delayed response |
Chonky 2.x release
Remaining todos:
ChonkyIconFA
into the (currently empty)chonky-icon-fontawesome
packageFileContextMenu
component is not enabledShow file array validation error in the UI & consoleValidation errors are only shown in console now for better UX.disableSelection
is set totrue
.FullFileBrowser
component.Stretch goals:
folderChainIcon
field toFileData
.Cannot have two HTML5 backends
error on hot reload even when using externalDnDProvider
s.TypeDoc
component in Docz.action.fileFilter
intoaciton.selectionFilter
(with backwards-compatible deprecation warning forfileFilter
).action.option.fileFilter
for hiding files (similar to built-in "Show hidden files" functionality).The text was updated successfully, but these errors were encountered: