configure button bindings #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9910000000008398842222222222222222222222222222222222222222222221022222222099999999929110000101122991022299991111111388749965883783
2 tasks
|
Currently fails all the checks |
|
If you look closely, many of the errors are in other files, so the checks
are detecting stuff like unicode errors and other stuff
Max
…On Thu, 19 Dec 2024 at 06:08, Ishan ***@***.***> wrote:
Currently fails all the checks
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4UR6C5OBA4M76NUH7WNJND2GKSK7AVCNFSM6AAAAABT3VJFHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJTGQZTOMRWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
_This message was sent from a student email account at the Chapel
Hill-Carrboro City Schools. All mail correspondence to and from Chapel
Hill-Carrboro City School students is subject to monitoring by district
administrators and may result in disclosure to law enforcement._
|
|
U can very clearly see the error is in RobotContainer, the file u changed. The error in MathUtil doesn't actually exist. It is just a comment. |
|
also it isn't formatted |
|
I downloaded a spotless extension for codespaces. Hlpefully it
workkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkk
Max
…On Thu, 19 Dec 2024 at 09:19, Ishan ***@***.***> wrote:
also it isn't formatted
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4UR6C2I6OPQWNVYEWVPWB32GLIYDAVCNFSM6AAAAABT3VJFHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJUGI2TIOBUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
_This message was sent from a student email account at the Chapel
Hill-Carrboro City Schools. All mail correspondence to and from Chapel
Hill-Carrboro City School students is subject to monitoring by district
administrators and may result in disclosure to law enforcement._
|
JacksonElia
reviewed
Dec 29, 2024
| public RobotContainer() { | ||
| configureBindings(); | ||
| } | ||
|
|
||
| private void configureBindings() {} | ||
| private void configureBindings() { | ||
| driverAButton.onTrue(new DriveCommand(null, null, null, null, null, driverAButton, driverAButton)); |
There was a problem hiding this comment.
why are we passing in null to this?
There was a problem hiding this comment.
bro it was hard enough to get @mychenezpz to write a button binding, id be proud of him for doing that lol. its null bc he didnt get to it ig
There was a problem hiding this comment.
ill write some better examples when i have time tmrw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.