Skip to content

auto factories #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 74 commits into from
Feb 13, 2025
Merged

auto factories #55

merged 74 commits into from
Feb 13, 2025

Conversation

aridavidson001
Copy link
Contributor

The use of triggers is really cool honestly. We can use them in robotContainer as well to bind certain commands to certain things(like moving the elevator to whatever level if we're x feet from the feeder station, or auto moving the elevator if we're doing auto-align with the reef).
Also the auto stuff is reallllllllly cool.

@aridavidson001 aridavidson001 changed the title moved auto stuff to robot.java, made it better(used choreo's autoChooser instead of a sendable chooser), and created an example auto in robot.java auto factories Jan 26, 2025
@Ishan1522
Copy link
Member

/format

@Ishan1522 Ishan1522 linked an issue Feb 2, 2025 that may be closed by this pull request
Copy link
Member

@JacksonElia JacksonElia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Ari, this looks great!

Next challenge is figuring out how to get pose estimation to work. I would talk with @Ishan1522 about how to do this as we need a command to extend DriveCommandBase but I'm not sure what is the best way to do that.

@JacksonElia JacksonElia mentioned this pull request Feb 4, 2025
6 tasks
Copy link
Member

@Ishan1522 Ishan1522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one pregunta por favor and gracias

@Ishan1522
Copy link
Member

/format

@Ishan1522
Copy link
Member

Next challenge is figuring out how to get pose estimation to work. I would talk with @Ishan1522 about how to do this as we need a command to extend DriveCommandBase but I'm not sure what is the best way to do that.

lol i forgot about this one good question, i think it shouldn't be bad tho.

lmao @JacksonElia another reason to not use DriveCommandBase

@Ishan1522
Copy link
Member

Make it pass da checks

Copy link
Member

@JacksonElia JacksonElia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love what we're doing for following trajectories now

@TitaniumTigers4829 TitaniumTigers4829 deleted a comment from Ishan1522 Feb 12, 2025
@JacksonElia JacksonElia added the enhancement New feature or request label Feb 13, 2025
Copy link
Member

@JacksonElia JacksonElia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just do some cleanup


public static final double MAX_ANGULAR_SPEED_RADIANS_PER_SECOND = 2;
public static final double MAX_ANGULAR_SPEED_RADIANS_PER_SECOND_SQUARED = 2;

public static final double CHOREO_AUTO_ACCEPTABLE_TRANSLATION_TOLERANCE = 0.01;

public static final double CHOREO_AUTO_ACCEPTABLE_ROTATION_TOLERANCE = 0.01;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can maybe be higher, like half a degree. Don't worry about it for now tho because we can iron these out later when we start doing autos with the robot

Copy link
Member

@JacksonElia JacksonElia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge it

@Ishan1522 Ishan1522 merged commit ad9901c into main Feb 13, 2025
4 checks passed
@aridavidson001 aridavidson001 deleted the auto-factories branch February 21, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

auto factories and such
3 participants