-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto factories #55
base: main
Are you sure you want to change the base?
auto factories #55
Conversation
…ser instead of a sendable chooser), created an example auto in robot.java
/format 😄 |
/format |
1 similar comment
/format |
src/main/java/frc/robot/commands/example/ExampleScoreL4Command.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/example/ExampleSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/example/ExampleSubsystem.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Ari, this looks great!
Next challenge is figuring out how to get pose estimation to work. I would talk with @Ishan1522 about how to do this as we need a command to extend DriveCommandBase but I'm not sure what is the best way to do that.
lol i forgot about this one good question, i think it shouldn't be bad tho. |
lemme look at the code more...... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one pregunta por favor and gracias
double moveY = sample.vy + yController.calculate(pose.getY(), sample.y); | ||
double moveTheta = | ||
sample.omega + headingController.calculate(pose.getRotation().getRadians(), sample.heading); | ||
drive(moveX, moveY, moveTheta, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JacksonElia would this method not correctly do pose estimation for following trajectories? i don't think it is used yet, but I'm pretty sure this would work no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suppose it can't estimate the pose if we aren't using the drive command lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could do pose estimation there i guess but then we don't get vision
(SwerveSample sample) -> { | ||
FollowChoreoTrajectory command = | ||
new FollowChoreoTrajectory(swerveDrive, visionSubsystem, sample); | ||
command.execute(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might not be correct. idk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh it seems weird just doing command.execute? I don't think this is right probably
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah me too lol im gonna test it today
src/main/java/frc/robot/subsystems/example/ExampleConstants.java
Outdated
Show resolved
Hide resolved
… Created constants for all of the paths we should have
/format |
Ok I'm actually so sorry I didn't get to test this yesterday but I pinky promise we will do it today |
…de-2025 into auto-factories
The use of triggers is really cool honestly. We can use them in robotContainer as well to bind certain commands to certain things(like moving the elevator to whatever level if we're x feet from the feeder station, or auto moving the elevator if we're doing auto-align with the reef).
Also the auto stuff is reallllllllly cool.