-
Notifications
You must be signed in to change notification settings - Fork 0
auto factories #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto factories #55
Conversation
…ser instead of a sendable chooser), created an example auto in robot.java
/format |
src/main/java/frc/robot/commands/example/ExampleScoreL4Command.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/example/ExampleSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/example/ExampleSubsystem.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Ari, this looks great!
Next challenge is figuring out how to get pose estimation to work. I would talk with @Ishan1522 about how to do this as we need a command to extend DriveCommandBase but I'm not sure what is the best way to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one pregunta por favor and gracias
/format |
lmao @JacksonElia another reason to not use DriveCommandBase |
Make it pass da checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love what we're doing for following trajectories now
src/main/java/frc/robot/commands/drive/FollowChoreoTrajectory.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/commands/drive/FollowChoreoTrajectory.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/commands/drive/FollowChoreoTrajectory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just do some cleanup
|
||
public static final double MAX_ANGULAR_SPEED_RADIANS_PER_SECOND = 2; | ||
public static final double MAX_ANGULAR_SPEED_RADIANS_PER_SECOND_SQUARED = 2; | ||
|
||
public static final double CHOREO_AUTO_ACCEPTABLE_TRANSLATION_TOLERANCE = 0.01; | ||
|
||
public static final double CHOREO_AUTO_ACCEPTABLE_ROTATION_TOLERANCE = 0.01; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can maybe be higher, like half a degree. Don't worry about it for now tho because we can iron these out later when we start doing autos with the robot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge it
The use of triggers is really cool honestly. We can use them in robotContainer as well to bind certain commands to certain things(like moving the elevator to whatever level if we're x feet from the feeder station, or auto moving the elevator if we're doing auto-align with the reef).
Also the auto stuff is reallllllllly cool.