Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESModules dependencies #400

Closed
TomerFi opened this issue Feb 27, 2024 · 0 comments · Fixed by #435
Closed

Support ESModules dependencies #400

TomerFi opened this issue Feb 27, 2024 · 0 comments · Fixed by #435
Labels
good first issue Good for newcomers help wanted Contributing help wanted type: enhancement New feature or request

Comments

@TomerFi
Copy link
Owner

TomerFi commented Feb 27, 2024

What did you have in mind?

Lately, A lot of NodeJS packages have migrated from CommonJS to ESModules. Which are not supported in this project. The following PRs are blocked:

Also, see TomerFi/github-viewer-stats#74.

This project is not consumed as a module, so it is only affected by the modules it consumes. It can either be migrated to ESModule or switched from require statements to dynamic import ones.

Are you trying to fix a problem?

No response

Any lead on how this feature can be implemented?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Contributing help wanted type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant