Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zenodo_get dependency and unit test errors #2074

Open
paskino opened this issue Feb 12, 2025 · 0 comments
Open

zenodo_get dependency and unit test errors #2074

paskino opened this issue Feb 12, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@paskino
Copy link
Contributor

paskino commented Feb 12, 2025

Description

I wonder whether some of our "dependencies" are actually dependencies. For instance zenodo_get is a new dependency but one may be using CIL without requiring it. Some unit test currently fail if that's not installed. Wouldn't it be more suitable to skip them?

https://github.com/SyneRBI/SIRF-SuperBuild/actions/runs/13288866230/job/37104246990?pr=937

I guess this requires a wider discussion about requirements and optional dependencies.

@paskino paskino added the bug Something isn't working label Feb 12, 2025
@paskino paskino changed the title zenodo_get dependency and unit test errors zenodo_get dependency and unit test errors Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant