Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some SQLFluff annotations are sometimes not annotated #9

Open
Nate-Wessel opened this issue Jan 30, 2024 · 2 comments
Open

Some SQLFluff annotations are sometimes not annotated #9

Nate-Wessel opened this issue Jan 30, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Nate-Wessel
Copy link
Collaborator

Some SQLFluff failures are not resulting in an annotation. In most/all cases, it seems like the failure is straightforwardly corresponding to a single line, i.e. it's nothing crazy complicated and doesn't seem like it's only effecting edges cases.

For example:

== [collisions/2024-01-19_i0581_Collisions_red-light_camera_group/i0581_rlc_collision_statistics.sql]
FAIL
L:  26 | P:   1 | LT08 | Blank line expected but not found after CTE closing
                       | bracket. [layout.cte_newline]

The action fails, but it doesn't give any feedback as to why.

I don't know why this is happening. I haven't see much of a pattern to it yet.

@Nate-Wessel Nate-Wessel added the bug Something isn't working label Jan 30, 2024
@Nate-Wessel Nate-Wessel self-assigned this Jan 30, 2024
@Nate-Wessel
Copy link
Collaborator Author

Just created yuzutech/annotations-action#68

I think I was seeing these as single-line annotations in the human-readable output from SQLFluff, but in the github annotations file, they were actually multi-line.

@Nate-Wessel
Copy link
Collaborator Author

Context on what these annotation output formats actually are: sqlfluff/sqlfluff#3106

Apparently this ONLY works with this specific action, and only partially at that.

But the other format also has some pretty major limitations! sqlfluff/sqlfluff#3857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant