Skip to content

Commit fc03190

Browse files
committed
ci: remove an unneeded cmake install step
The `static_build_cmake_linux` workflow installs CMake 3.17, because it needs ctest's `--repeat until-pass:3` option. However, now a previous step ensures that CMake 3.26 is installed (related commands were added into `install-deps-debian`). The original motivation behind the removed step was to upgrade CMake, but now the step downgrades it, which makes little sense. For those who worry whether we verify the build with an older CMake version: we have CMake 3.18 in the CentOS 7 job of the `distrib` workflow, and 3.18 will be the new minimum supported version soon (see the linked issue). Part of tarantool#13306 NO_DOC=ci NO_CHANGELOG=ci NO_TEST=ci
1 parent 1491b65 commit fc03190

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

‎.github/workflows/static_build_cmake_linux.yml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,6 @@ jobs:
8989
with:
9090
submodule: ${{ inputs.submodule }}
9191
revision: ${{ inputs.revision }}
92-
# Install CMake using PyPI, because option
93-
# `--repeat until-pass:3` required by CTest was added since
94-
# CMake 3.17.
95-
- name: install cmake
96-
run: |
97-
apt -y remove cmake
98-
pip3 install cmake==3.17.3
9992
- name: test
10093
run: make -f .test.mk test-static-cmake
10194
- name: Send VK Teams message on failure

0 commit comments

Comments
 (0)