Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clicking outside when modal mode is disabled #1537

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: clicking outside when modal mode is disabled #1537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/WindowsViewport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function WindowsViewport({ children }: PropsWithChildren<unknown>): JSX.E

const { zIndex } = useTheme();
return (
<div className={cx(fullscreenFixed, ignorePointerEvents, css({ zIndex }))} ref={observe}>
<div id={"windowsViewport"} className={cx(fullscreenFixed, ignorePointerEvents, css({ zIndex }))} ref={observe}>
<ViewportContext.Provider value={value}>{children}</ViewportContext.Provider>
</div>
);
Expand Down
4 changes: 2 additions & 2 deletions src/components/window/WindowFrame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ export const WindowFrame = forwardRef((props: PropsWithChildren<WindowFrameProps
useScrollFix(ref.current);

return (
<div ref={windowRef} style={{ height: "100%" }}>
<div ref={windowRef}>
{/*fallback animation for lazy loaded content*/}
<CSSTransition nodeRef={ref} in={contentAvailable} timeout={250} classNames={fadeInAnimation}>
<CSSTransition in={maximized} timeout={250} classNames={zoomAnimation} onEnter={onEnter} onExited={onExited}>
Expand All @@ -286,7 +286,7 @@ export const WindowFrame = forwardRef((props: PropsWithChildren<WindowFrameProps
enableResizing={resizable && !maximized}
className={cx(windowClass, windowTheme)}
style={{ display: "flex", zIndex }} // override default inline-block
bounds="parent"
bounds="#windowsViewport"
size={size}
position={maximized ? { x: 0, y: 0 } : position}
minWidth={currentMinWidth}
Expand Down
Loading