Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.15.0 release #35

Merged
merged 8 commits into from
May 23, 2024
Merged

1.15.0 release #35

merged 8 commits into from
May 23, 2024

Conversation

ForrestFairy
Copy link
Contributor

Bump Nussknacker to 1.15.0

Updated CsvSource to extend StandardFlinkSource

@ForrestFairy ForrestFairy requested a review from mslabek May 23, 2024 08:54
@@ -20,7 +20,7 @@ class SampleComponentProviderTest extends Matchers with ValidatedValuesDetailedM
.streaming("test scenario")
.source("custom-source-node-name", TestScenarioRunner.testDataSource)
.enricher("component-provider-service-node-name", "output", "randomString", "length" -> "#input")
.processorEnd("end", TestScenarioRunner.testResultService, "value" -> "#output")
.emptySink("end", TestScenarioRunner.testResultSink, "value" -> "#output")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change from processorEnd to emptySink but otherwise a
The Validated on which validValue was invoked was defined as Invalid(NonEmptyList(MissingService(sink,end))) error is thrown

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its ok, it was done analogically in main repo tests after TestRunner refactor

@ForrestFairy ForrestFairy marked this pull request as ready for review May 23, 2024 10:26
Copy link
Member

@mslabek mslabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ForrestFairy ForrestFairy merged commit 5bda11e into staging May 23, 2024
1 check passed
@ForrestFairy ForrestFairy deleted the 1.15.0-release branch May 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants