diff --git a/designer/client/cypress/e2e/nodeWindow.cy.ts b/designer/client/cypress/e2e/nodeWindow.cy.ts index daa1a857439..219a29cac25 100644 --- a/designer/client/cypress/e2e/nodeWindow.cy.ts +++ b/designer/client/cypress/e2e/nodeWindow.cy.ts @@ -19,7 +19,7 @@ describe("Node window", () => { .should("exist") .scrollIntoView(); cy.layoutScenario(); - cy.get("[data-testid='component:event-generator']") + cy.get("[data-testid='component:event generator']") .should("be.visible") .drag("#nk-graph-main", { target: { @@ -29,7 +29,7 @@ describe("Node window", () => { force: true, }); - cy.getNode("event-generator").dblclick(); + cy.getNode("event generator").dblclick(); // TODO: fix validation display in node windows cy.intercept("POST", "/api/nodes/*/validation").as("validation"); diff --git a/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/component/package.scala b/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/component/package.scala index 617fe1eb030..492ce3fa580 100644 --- a/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/component/package.scala +++ b/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/component/package.scala @@ -53,46 +53,6 @@ package object component { object ComponentListElement { def sortMethod(component: ComponentListElement): (String, String) = (component.name, component.id.value) - - def apply( - id: DesignerWideComponentId, - name: String, - icon: String, - componentType: ComponentType, - componentGroupName: ComponentGroupName, - categories: List[String], - links: List[ComponentLink], - usageCount: Long, - allowedProcessingModes: AllowedProcessingModes - ): ComponentListElement = { - if (componentType == ComponentType.Fragment) - ComponentListElement( - id, - name, - icon, - componentType, - componentGroupName, - categories, - links, - usageCount, - allowedProcessingModes, - id.value - ) - else - ComponentListElement( - id, - name, - icon, - componentType, - componentGroupName, - categories, - links, - usageCount, - allowedProcessingModes, - name - ) - } - } implicit val allowedProcessingModesEncoder: Encoder[AllowedProcessingModes] = Encoder.instance { diff --git a/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/definition/package.scala b/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/definition/package.scala index a73ad0f9936..73493771f68 100644 --- a/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/definition/package.scala +++ b/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/definition/package.scala @@ -70,8 +70,7 @@ package object definition { icon: String, docsUrl: Option[String], // This field is defined only for fragments - outputParameters: Option[List[String]], - label: String + outputParameters: Option[List[String]] ) @JsonCodec final case class UISourceParameters(sourceId: String, parameters: List[UIParameter]) diff --git a/designer/server/src/main/scala/pl/touk/nussknacker/ui/definition/DefinitionsService.scala b/designer/server/src/main/scala/pl/touk/nussknacker/ui/definition/DefinitionsService.scala index 58ae70c2028..fce28f475ce 100644 --- a/designer/server/src/main/scala/pl/touk/nussknacker/ui/definition/DefinitionsService.scala +++ b/designer/server/src/main/scala/pl/touk/nussknacker/ui/definition/DefinitionsService.scala @@ -137,8 +137,7 @@ class DefinitionsService( docsUrl = componentDefinition.component.docsUrl, outputParameters = Option(componentDefinition.component.componentTypeSpecificData).collect { case FragmentSpecificData(outputNames) => outputNames - }, - label = componentDefinition.component.label + } ) } diff --git a/designer/server/src/test/scala/pl/touk/nussknacker/ui/definition/component/DefaultComponentServiceSpec.scala b/designer/server/src/test/scala/pl/touk/nussknacker/ui/definition/component/DefaultComponentServiceSpec.scala index 55149ffee36..7edee27ff6e 100644 --- a/designer/server/src/test/scala/pl/touk/nussknacker/ui/definition/component/DefaultComponentServiceSpec.scala +++ b/designer/server/src/test/scala/pl/touk/nussknacker/ui/definition/component/DefaultComponentServiceSpec.scala @@ -366,7 +366,8 @@ class DefaultComponentServiceSpec availableCategories, links, usageCount, - nonDefaultAllowedProcessingModes.getOrElse(AllowedProcessingModes.All) + nonDefaultAllowedProcessingModes.getOrElse(AllowedProcessingModes.All), + componentId.name ) } @@ -386,7 +387,8 @@ class DefaultComponentServiceSpec List(cat), links, 0, - AllowedProcessingModes.SetOf(ProcessingMode.UnboundedStream) + AllowedProcessingModes.SetOf(ProcessingMode.UnboundedStream), + componentId.name ) ) } @@ -406,7 +408,8 @@ class DefaultComponentServiceSpec List(cat), links, 0, - AllowedProcessingModes.SetOf(ProcessingMode.UnboundedStream) + AllowedProcessingModes.SetOf(ProcessingMode.UnboundedStream), + componentId.name ) ) } @@ -470,7 +473,8 @@ class DefaultComponentServiceSpec categories, links, usageCount, - nonDefaultAllowedProcessingModes.getOrElse(AllowedProcessingModes.All) + nonDefaultAllowedProcessingModes.getOrElse(AllowedProcessingModes.All), + componentId.name, ) } diff --git a/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/definition/component/ComponentDefinitionWithImplementation.scala b/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/definition/component/ComponentDefinitionWithImplementation.scala index cc3f1bf8c12..f115c1d8346 100644 --- a/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/definition/component/ComponentDefinitionWithImplementation.scala +++ b/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/definition/component/ComponentDefinitionWithImplementation.scala @@ -32,7 +32,15 @@ trait ComponentDefinitionWithImplementation extends ObjectOperatingOnTypes { protected def uiDefinition: ComponentUiDefinition - final def label: String = uiDefinition.label.getOrElse(name) + final def label: String = { + uiDefinition.label.getOrElse { + if (componentType != ComponentType.Fragment) { + name + } else { + id.name + } + } + } final def designerWideId: DesignerWideComponentId = uiDefinition.designerWideId diff --git a/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/definition/component/defaultconfig/DefaultComponentConfigDeterminer.scala b/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/definition/component/defaultconfig/DefaultComponentConfigDeterminer.scala index c05d46cf055..9469c1ce4cf 100644 --- a/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/definition/component/defaultconfig/DefaultComponentConfigDeterminer.scala +++ b/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/definition/component/defaultconfig/DefaultComponentConfigDeterminer.scala @@ -78,7 +78,7 @@ object DefaultComponentConfigDeterminer { icon = icon.getOrElse(DefaultsComponentIcon.FragmentIcon), docsUrl = docsUrl, designerWideId = designerWideId, - label = Option(designerWideId.value) + label = None ) }