Use precise QtTimer types.

Default coarse only tried to keep accuracy within 5% of the desired interval
Also use constants instead of magic number 1000

Author: Avasam

src/AutoSplit.py

@@ -41,6 +41,7 @@
     AUTOSPLIT_VERSION,
     BGRA_CHANNEL_COUNT,
     FROZEN,
+    ONE_SECOND,
     auto_split_directory,
     decimal,
     flatten,
@@ -76,7 +77,9 @@ class AutoSplit(QMainWindow, design.Ui_MainWindow):
 
     # Timers
     timer_live_image = QtCore.QTimer()
+    timer_live_image.setTimerType(QtCore.Qt.TimerType.PreciseTimer)
     timer_start_image = QtCore.QTimer()
+    timer_start_image.setTimerType(QtCore.Qt.TimerType.PreciseTimer)
 
     # Widgets
     AboutWidget: about.Ui_AboutAutoSplitWidget | None = None
@@ -205,7 +208,7 @@ def _update_checker_widget_signal_slot(latest_version: str, check_on_open: bool)
 
         # live image checkbox
         self.timer_live_image.timeout.connect(lambda: self.__update_live_image_details(None, True))
-        self.timer_live_image.start(int(1000 / self.settings_dict["fps_limit"]))
+        self.timer_live_image.start(int(ONE_SECOND / self.settings_dict["fps_limit"]))
 
         # Automatic timer start
         self.timer_start_image.timeout.connect(self.__start_image_function)
@@ -296,7 +299,7 @@ def __load_start_image(self, started_by_button: bool = False, wait_for_delay: bo
         self.highest_similarity = 0.0
         self.reset_highest_similarity = 0.0
         self.split_below_threshold = False
-        self.timer_start_image.start(int(1000 / self.settings_dict["fps_limit"]))
+        self.timer_start_image.start(int(ONE_SECOND / self.settings_dict["fps_limit"]))
 
         QApplication.processEvents()
 
@@ -341,7 +344,7 @@ def __start_image_function(self):
                 if self.start_image.get_delay_time(self) > 0:
                     self.start_image_status_value_label.setText("delaying start...")
                     delay_start_time = time()
-                    start_delay = self.start_image.get_delay_time(self) / 1000
+                    start_delay = self.start_image.get_delay_time(self) / ONE_SECOND
                     time_delta = 0.0
                     while time_delta < start_delay:
                         delay_time_left = start_delay - time_delta
@@ -564,7 +567,7 @@ def __auto_splitter(self):  # noqa: PLR0912,PLR0915
         while self.split_image_number < number_of_split_images:
             # Check if we are not waiting for the split delay to send the key press
             if self.waiting_for_split_delay:
-                time_millis = int(round(time() * 1000))
+                time_millis = int(round(time() * ONE_SECOND))
                 if time_millis < split_time:
                     QApplication.processEvents()
                     continue
@@ -583,9 +586,9 @@ def __auto_splitter(self):  # noqa: PLR0912,PLR0915
             if not self.split_image.check_flag(DUMMY_FLAG):
                 # If it's a delayed split, check if the delay has passed
                 # Otherwise calculate the split time for the key press
-                split_delay = self.split_image.get_delay_time(self) / 1000
+                split_delay = self.split_image.get_delay_time(self) / ONE_SECOND
                 if split_delay > 0 and not self.waiting_for_split_delay:
-                    split_time = round(time() + split_delay * 1000)
+                    split_time = round(time() + split_delay * ONE_SECOND)
                     self.waiting_for_split_delay = True
                     buttons_to_disable = [
                         self.next_image_button,
@@ -668,7 +671,7 @@ def __similarity_threshold_loop(self, number_of_split_images: int, dummy_splits_
             # Limit the number of time the comparison runs to reduce cpu usage
             frame_interval = 1 / self.settings_dict["fps_limit"]
             # Use a time delta to have a consistant check interval
-            wait_delta_ms = int((frame_interval - (time() - start) % frame_interval) * 1000)
+            wait_delta_ms = int((frame_interval - (time() - start) % frame_interval) * ONE_SECOND)
 
             below_flag = self.split_image.check_flag(BELOW_FLAG)
             # if the b flag is set, let similarity go above threshold first,

src/menu_bar.py

@@ -22,7 +22,7 @@
 )
 from gen import about, design, settings as settings_ui, update_checker
 from hotkeys import HOTKEYS, Hotkey, set_hotkey
-from utils import AUTOSPLIT_VERSION, GITHUB_REPOSITORY, decimal, fire_and_forget
+from utils import AUTOSPLIT_VERSION, GITHUB_REPOSITORY, ONE_SECOND, decimal, fire_and_forget
 
 if TYPE_CHECKING:
     from AutoSplit import AutoSplit
@@ -231,7 +231,7 @@ def __capture_device_changed(self):
     def __fps_limit_changed(self, value: int):
         value = self.fps_limit_spinbox.value()
         self._autosplit_ref.settings_dict["fps_limit"] = value
-        self._autosplit_ref.timer_live_image.setInterval(int(1000 / value))
+        self._autosplit_ref.timer_live_image.setInterval(int(ONE_SECOND / value))
 
     @fire_and_forget
     def __set_all_capture_devices(self):

src/utils.py

@@ -24,7 +24,8 @@
 
 T = TypeVar("T")
 
-
+ONE_SECOND = 1000
+"""1000 milliseconds in 1 second"""
 DWMWA_EXTENDED_FRAME_BOUNDS = 9
 MAXBYTE = 255
 BGR_CHANNEL_COUNT = 3