-
Notifications
You must be signed in to change notification settings - Fork 50
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: typed jest conf + remove
version
from compose file + fix typo (
#337) Just some chores like getting rid of this warning in terminal each time you run e2e tests: ```shell WARN[0000] /home/kasir/projects/nestjs-query/examples/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion ``` Typed jest conf file for better dev exp when you need to modify it. Some typos that where here an there. BTW I also like to ask @TriPSs why he has increased the `printWidth` of prettier to 130! I mean the recommended length is 70. So if your OK with it I am gonna change it to 70. TBH it is really long and hard to make sense of a lot of stuff. But I am also open to not touch it since it is growing on me too (as of lately I feel more comfortable around it :sweat_smile:). One thing that bothers me though is that if I save `docker-compose.yml` or any `JSON` conf file my IDE format it and I was thinking if possible either override them in `.prettierrc` or decrease the `printWidth` to 70 since the only configuration that causes VSCode to format them in my case.
- Loading branch information
Showing
6 changed files
with
27 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
version: "3" | ||
|
||
services: | ||
postgres: | ||
image: "postgres:14" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters