Skip to content

Commit ce83c91

Browse files
committed
fix(login): fix regression that removed support for setting custom cookieMaxAge
regression introduced with #401 custom cookieMaxAge feature added with #1156 fixes #1709
1 parent 3a3f5be commit ce83c91

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/routes/login.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,10 @@ function login(req: Request, res: Response) {
9292
const rememberMe = req.body.rememberMe;
9393

9494
req.session.regenerate(() => {
95-
if (rememberMe) {
96-
req.session.cookie.maxAge = 21 * 24 * 3600000; // 3 weeks
97-
} else {
95+
if (!rememberMe) {
9896
// unset default maxAge set by sessionParser
99-
// Cookie becomes non-persistent and expires after current browser session (e.g. when browser is closed)
97+
// Cookie becomes non-persistent and expires
98+
// after current browser session (e.g. when browser is closed)
10099
req.session.cookie.maxAge = undefined;
101100
}
102101

0 commit comments

Comments
 (0)