Skip to content

Consider deleting unused electron locales from release builds #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pano9000 opened this issue Jan 31, 2025 · 1 comment
Open

Consider deleting unused electron locales from release builds #1090

pano9000 opened this issue Jan 31, 2025 · 1 comment

Comments

@pano9000
Copy link
Member

Describe Task

Hi,

I was noticing that the Desktop Electron build comes with a folder called "locales" which includes 55 locale files – most of which are locales, we don't even have our own translations for.

Deleting these files from the folder (I only left en-US.pak) – and I don't notice any issues or differences with the app.

Not sure if there are any Electron Gurus out here, but are there any reasons against deleting these locales?

I found another Github comment that seems to say, that it worked for them:
electron-userland/electron-builder#7506 (comment)

It would scrape off a good 40MB (uncompressed) off the build (or ~10MB compressed from the release file), which I think is not too bad :-)

@pano9000
Copy link
Member Author

https://www.npmjs.com/package/electron-packager-languages
electron/forge#2248 (different files, but similar desired outcome of deleting unneeded files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant