Node Version?

[eightysixed]

I am migrating over to TriliumNext and figured I might as well roll with a manual server install. I wanted to double check the node version, but in the (what seems to be) outdated documentation mentions 14 and 16 only being supported and tested. I was hoping it'd be compatible with at least v20. I don't need anything past thing, I wouldn't think, yet?

Basically, on a brand new server install what version of Node is recommended for TriliumNext, and where should I go put in a PR to make it known? :)

[eightysixed]

Nevermind. Node 22.
Anything game-breaking if I stay on v20?

The Docs are uneditable though :)

[eliandoran]

@eightysixed , indeed, it's Node 22.

That page of documentation could use some love, yes.
If you wish to contribute, it's been relocated in the Notes repo, you can modify it in docs\User Guide\User Guide\Installation & Setup\Server Installation\1. Installing the server\Manually.md.

[eightysixed]

Okay, will do 👍

Is 22 required or just supported?
I'd rather keep everything on 20 for the moment if possible :)

[pano9000]

for building the project from source, 22 is definitely required — for running it, I think v20 should work as well.

Give me a minute, I'll do a test build with v20 runtime and confirm back

[eliandoran]

Indeed, at application level we enforce at least Node 20. I believe Electron uses (or at least used at some point) Node 20 so we could not enforce Node 22.

Generally we encourage using the latest LTS versions when possible.

[pano9000]

interestingly though: for the Server build (using the build-server script locally) → using v20.19.0 produces a crash when trying to run it

pano@elitebook:~/Programming/0_repos/TriliumNextNotes/dist/TriliumNextNotes-Server-0.92.7-linux-x64$ ./node/bin/node -v
v20.19.0
pano@elitebook:~/Programming/0_repos/TriliumNextNotes/dist/TriliumNextNotes-Server-0.92.7-linux-x64$ ./node/bin/node src/main.js


#
# Fatal error in , line 0
# Check failed: module->status() == kLinked || module->status() == kEvaluated.
#
#
#
#FailureMessage Object: 0x7fff50f5ba30
----- Native stack trace -----

 1: 0xd43461  [./node/bin/node]
 2: 0x218e601 V8_Fatal(char const*, ...) [./node/bin/node]
 3: 0x1414892 v8::internal::SourceTextModule::Evaluate(v8::internal::Isolate*, v8::internal::Handle<v8::internal::SourceTextModule>) [./node/bin/node]
 4: 0xf25daa v8::Module::Evaluate(v8::Local<v8::Context>) [./node/bin/node]
 5: 0xc76b6b node::loader::ModuleWrap::Evaluate(v8::FunctionCallbackInfo<v8::Value> const&) [./node/bin/node]
 6: 0xf6c56f v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [./node/bin/node]
 7: 0xf6cddd  [./node/bin/node]
 8: 0xf6d2a5 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [./node/bin/node]
 9: 0x1977df6  [./node/bin/node]
Trace/Breakpoint ausgelöst (Speicherabzug geschrieben)

will need to check this evening, if that is an issue on my side only though

[eliandoran]

@pano9000 , did you rebuild the native dependencies? Try rm -rf node_modules followed by npm install on Node v20.

[eliandoran]

@eightysixed , here's the documentation on how to edit the documentation: https://github.com/TriliumNext/Notes/blob/develop/docs/Developer%20Guide/Developer%20Guide/Documentation.md

Since you are not modifying the structure, it's feasible for you to modify the Markdown document directly. More complex changes require npm run docs:edit.

[eightysixed]

I'm glad I looked into this, actually. The only reason I was holding back on 22 was because of umami-software/umami. That was bumped to 22 two months ago. Thanks for looking into this regardless!

Thanks for the documentation on the documentation :) I found that earlier. I'll give it a shot on a dev server that's using 20 just to test what I was already asking, but ultimately land on 22 anyway. I'll leave this open for the weekend :)

[eightysixed]

Okay, good news! (And bad, maybe?)

TriliumNext does, indeed, work fine on Node v20! And obviously it works fine on Node v22.

However, some of the warnings from the dependencies are worth a second glance.

npm -v
10.9.2

node -v
v22.14.0

npm install
npm warn skipping integrity check for git dependency ssh://git@github.com/electron/node-gyp.git
npm warn deprecated sudo-prompt@9.2.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated lodash.isequal@4.5.0: This package is deprecated. Use require('node:util').isDeepStrictEqual instead.
npm warn deprecated lodash.get@4.4.2: This package is deprecated. Use the optional chaining (?.) operator instead.
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which i>
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated gar@1.0.4: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated boolean@3.2.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated asar@3.2.0: Please use @electron/asar moving forward.  There is no API change, just a package name change
npm warn deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
npm warn deprecated rimraf@2.6.3: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.1.6: Glob versions prior to v9 are no longer supported
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@8.1.0: Glob versions prior to v9 are no longer supported
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@8.1.0: Glob versions prior to v9 are no longer supported

Same thing on 20, but it works, so that's the neat part. I'm sure I won't be the last person to wonder, so I'll make sure it gets reflected. And then obviously remove it once that's no longer the case.

The two of main concern I think wold be inflight@1.0.6 due to a memory leak. I would think most users leave TriliumNext open more often that not, although I don't know how often that's called, as I haven't really looked into this too deep yet. And asar@3.2.0 being as it's been moved, but again I don't know how often its used.

I've been using TriliumNext for awhile now, but finishing a migration this weekend. Good news is, the original question is answered. Built for 22, works on 20. TriliumNext seems update often, so I'll slowly chip away at some of the docs when I can/where necessary. So the main question I suppose, I answered just by giving it a shot, so now we all know and I'll make sure to update the docs.

What about the memory leak dependency? I understand deprecated packages and warns, but that one may need a second glance, possibly. And the the others, curiously? Does the ML comment warrant its own PR?

Anyway, TriliumNext does work on Node 20. I'll leave this open for advisement/comment on the above.
At least we can say with certainty it does work fine otherwise on 20 :)

[eightysixed]

Just to be clear this is directly from git clone https://github.com/TrilliumNext/Notes.git on both Node 22 & 20.

edit: Nevermind - #5280

I'm not sure I've seen a Sticky on Github before. Cheers.

Alright, fair enough. I'll wait until tomorrow to close or an acknowledgment. Thanks!

edit2: https://developer.mend.io//github/TriliumNext/Notes - This seems to be broken, so I guess the dependency question still remains :)

[pano9000]

most of these warnings come from "transitive dependencies", which are a bit out of our direct control.

I did just push a commit that will get rid of the "asar" warning though :-)