Skip to content

Retest is broken #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JaimeRZP opened this issue Jun 29, 2023 · 3 comments
Closed

Retest is broken #327

JaimeRZP opened this issue Jun 29, 2023 · 3 comments

Comments

@JaimeRZP
Copy link
Member

Dear team,

Recently I have noticed that the this CUDA.jl test is broken due to an issue in ReTest.jl detailed here . In #325 I have commented this test out and added a comment referring to the ReTest.jl issue.

The reason why this has gone unnoticed is becuase GitHub's CI does not have a GPU so the test was never ran.

@torfjelde suggested getting rid of Retest.jl all together since the library seems to be old.

All the best,
Jaime
@yebai
Copy link
Member

yebai commented Jun 29, 2023

cc @xukai92

@xukai92
Copy link
Member

xukai92 commented Jul 17, 2023

I'm happy to remove ReTest if it introduces difficulties to maintenance.

@torfjelde torfjelde mentioned this issue Aug 28, 2023
Merged
9 tasks
@yebai yebai mentioned this issue Apr 23, 2025
Closed
@ErikQQY
Copy link
Collaborator

ErikQQY commented Apr 25, 2025

The GPU tests are moved to a special testing environment without ReTest.jl, so they will not be affected by ReTest.jl, but we can still safely use ReTest.jl for other tests. So I am closing this issue, but feel free to reopen if there are any other problems😃

@ErikQQY ErikQQY closed this as completed Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yebai @xukai92 @JaimeRZP @ErikQQY