Skip to content

Fix GeneralisedFilters documentation building #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yebai opened this issue Mar 10, 2025 · 4 comments
Closed

Fix GeneralisedFilters documentation building #69

yebai opened this issue Mar 10, 2025 · 4 comments
Assignees

Comments

@yebai
Copy link
Member

yebai commented Mar 10, 2025

No description provided.

@THargreaves
Copy link
Collaborator

THargreaves commented Apr 3, 2025

@shravanngoswamii Could you please have a luck at the state of this PR:
#77

I've added some debugging to the workflow to figure out what is going wrong.

It appears that SSMProblems.jl is correctly being dev-ed in the Documentation.yml workflow (v0.5.2) but then when DocsDocumenter.yml is ran, it doesn't pick up on this dev-ed version (still v0.4.0).

This is a bit confusing to me since both actions are using ${{ matrix.pkg.dir }}/docs for their Julia project so the dev-ing of SSMProblems in the calling action should be reflected in DocsDocumenter.yml.

Maybe I have a misunderstanding about how GitHub actions works.

@charlesknipp
Copy link
Member

charlesknipp commented Apr 3, 2025

I think this line in DocsDocumentor.yml is causing problems since we re-instantiate without dev-ing into SSMProblems.jl

    - name: Install docs dependencies
      shell: julia --color=yes --project=${{ inputs.doc-path }} {0}
      env:
        INPUT_PKG_PATH: ${{ inputs.pkg_path }}
      run: |
        using Pkg
        pkg_path = ENV["INPUT_PKG_PATH"]
        if pkg_path == ""
          Pkg.develop(PackageSpec(path=pwd()))
        else
          Pkg.develop(PackageSpec(path=pkg_path))
        end
        Pkg.instantiate()

@THargreaves
Copy link
Collaborator

I must have a misunderstanding of how instantiating (or GitHub actions) works.

I thought it installed everything exactly as listed in the Manifest.toml. Since we had dev-ed SSMProblems in the calling action, and we are using the same the same project path, I thought it would pick up on this.

@shravanngoswamii
Copy link
Member

@THargreaves, Sorry for the late response! I’ve been quite busy over the past few weeks, so I didn’t get a chance to reply sooner. I guess the issue has already been solved, but thanks for handling it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants