Skip to content

Commit f91cbc2

Browse files
devmotionyebai
authored andcommitted
* Fix TuringLang/DynamicPPL.jl#27 * Add regression test * Fix test error on Julia 1.0
1 parent 1dc1158 commit f91cbc2

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

src/inference/Inference.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -696,7 +696,7 @@ function dot_assume(
696696
var::AbstractMatrix,
697697
vi::VarInfo,
698698
)
699-
@assert dim(dist) == size(var, 1)
699+
@assert length(dist) == size(var, 1)
700700
r = get_and_set_val!(vi, vns, dist, spl)
701701
lp = sum(logpdf_with_trans(dist, r, istrans(vi, vns[1])))
702702
var .= r

src/inference/hmc.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ function dot_assume(
459459
var::AbstractMatrix,
460460
vi::VarInfo,
461461
)
462-
@assert dim(dist) == size(var, 1)
462+
@assert length(dist) == size(var, 1)
463463
updategid!.(Ref(vi), vns, Ref(spl))
464464
r = vi[vns]
465465
var .= r

test/inference/hmc.jl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,4 +183,14 @@ include(dir*"/test/test_utils/AllUtils.jl")
183183
@test sample(gdemo_default, alg2, 300) isa Chains
184184
@test sample(gdemo_default, alg3, 300) isa Chains
185185
end
186+
187+
@turing_testset "Regression tests" begin
188+
# https://github.com/TuringLang/DynamicPPL.jl/issues/27
189+
@model mwe(::Type{T}=Float64) where {T<:Real} = begin
190+
m = Matrix{T}(undef, 2, 3)
191+
@. m ~ MvNormal(zeros(2), 1)
192+
end
193+
194+
@test sample(mwe(), HMC(0.2, 4), 1_000) isa Chains
195+
end
186196
end

0 commit comments

Comments
 (0)