Merge pull request #956 from TwilioDevEd/fix-node-snippets

Fix node snippets linter issues

Author: jefflinwood

Diff for: ip-messaging/reachability-indicator/process-user-updates/process-user-updates.js

@@ -8,9 +8,9 @@ function registerEventHandlers() {
 // function to handle User updates
 function handleUserUpdate(user, updateReasons) {
   // loop over each reason and check for reachability change
-  updateReasons.forEach(reason =>
+  updateReasons.forEach(reason => {
     if (reason == 'online') {
       //do something
     }
-  )
+  })
 }

Diff for: rest/subaccounts/exchanging-numbers-example-1/exchanging-numbers-example-1.3.x.js

@@ -7,4 +7,4 @@ const client = require('twilio')(accountSid, authToken);
 
 client.incomingPhoneNumbers('PNXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
   .update({accountSid: process.env.TWILIO_SUB_ACCOUNT_SID})
-  .then(incoming_phone_number => console.log(incoming_phone_number.friendlyName));
+  .then(incomingPhoneNumber => console.log(incomingPhoneNumber.friendlyName));

Diff for: rest/taskrouter/jwts/worker/example-1/example-1.2.x.js

@@ -1,20 +1,20 @@
 // Download the Node helper library from twilio.com/docs/node/install
 // These vars are your accountSid and authToken from twilio.com/user/account
-var twilio = require('twilio');
+const twilio = require('twilio');
 
-var accountSid = process.env.TWILIO_ACCOUNT_SID;
-var authToken = process.env.TWILIO_AUTH_TOKEN;
-var workspaceSid = "WSXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX";
-var workerSid = "WKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX";
+const accountSid = process.env.TWILIO_ACCOUNT_SID;
+const authToken = process.env.TWILIO_AUTH_TOKEN;
+const workspaceSid = "WSXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX";
+const workerSid = "WKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX";
 
-var capability = new twilio.TaskRouterWorkerCapability(accountSid, authToken, workspaceSid, workerSid);
+const capability = new twilio.TaskRouterWorkerCapability(accountSid, authToken, workspaceSid, workerSid);
 capability.allowFetchSubresources();
 capability.allowActivityUpdates();
 capability.allowReservationUpdates();
-var token = capability.generate();
+let token = capability.generate();
 
 // By default, tokens are good for one hour.
 // Override this default timeout by specifiying a new value (in seconds).
 // For example, to generate a token good for 8 hours:
 
-var token = capability.generate(28800);  // 60 * 60 * 8
+token = capability.generate(28800);  // 60 * 60 * 8

Diff for: video/rest/compositions/compose-mosaic/compose-mosaic.3.x.js

@@ -16,7 +16,7 @@ client.video.compositions.
   create({
     roomSid: 'RMXXXX',
     audioSources: '*',
-    audioSourcesExcluded: 'advisor-audio'
+    audioSourcesExcluded: 'advisor-audio',
     videoLayout: {
         interviewed: {
           z_pos: 2,

Diff for: video/rest/rooms/recording-rules-audio-all/recording-rules-audio-all.3.x.js

@@ -8,4 +8,4 @@ const client = require('twilio')(accountSid, authToken);
 client.video.rooms('RMXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
             .recordingRules
             .update({rules: [{"type": "include", "kind": "audio"}]})
-            .then(recording_rules => console.log(recording_rules.roomSid));
+            .then(recordingRules => console.log(recordingRules.roomSid));

Diff for: video/rest/rooms/recording-rules-one-participant/recording-rules-one-participant.3.x.js

@@ -8,4 +8,4 @@ const client = require('twilio')(accountSid, authToken);
 client.video.rooms('RMXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
             .recordingRules
             .update({rules: [{"type": "include", "publisher": "Alice"}, {"type": "include", "kind": "audio"}]})
-            .then(recording_rules => console.log(recording_rules.roomSid));
+            .then(recordingRules => console.log(recordingRules.roomSid));

Diff for: video/rest/rooms/recording-rules-start-all/recording-rules-start-all.3.x.js

@@ -8,4 +8,4 @@ const client = require('twilio')(accountSid, authToken);
 client.video.rooms('RMXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
             .recordingRules
             .update({rules: [{"type": "include", "all": true}]})
-            .then(recording_rules => console.log(recording_rules.roomSid));
+            .then(recordingRules => console.log(recordingRules.roomSid));

Diff for: video/rest/rooms/recording-rules-stop-all/recording-rules-stop-all.3.x.js

@@ -8,4 +8,4 @@ const client = require('twilio')(accountSid, authToken);
 client.video.rooms('RMXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
             .recordingRules
             .update({rules: [{"type": "exclude", "all": true}]})
-            .then(recording_rules => console.log(recording_rules.roomSid));
+            .then(recordingRules => console.log(recordingRules.roomSid));