pref: build is now async. This means you can start a build and *still* continue to do your work.

refs #27
TIP: don't have any `console.log` anymore in programManager

Author: basarat

lib/main/atomts.js

@@ -113,11 +113,12 @@ function activate(state) {
     atom.commands.add('atom-text-editor', 'typescript:build', function (e) {
         if (!commandForTypeScript(e))
             return;
+        var editor = atom.workspace.getActiveTextEditor();
+        var filePath = editor.getPath();
         atom.notifications.addInfo('Building');
-        setTimeout(function () {
-            var outputs = commandGetProgram().build();
-            buildView.setBuildOutput(outputs);
-        }, 100);
+        parent.build({ filePath: filePath }).then(function (resp) {
+            buildView.setBuildOutput(resp.outputs);
+        });
     });
     atom.commands.add('atom-text-editor', 'typescript:go-to-declaration', function (e) {
         if (!commandForTypeScript(e))

lib/main/atomts.ts

@@ -199,12 +199,14 @@ export function activate(state: PackageState) {
     atom.commands.add('atom-text-editor', 'typescript:build',(e) => {
         if (!commandForTypeScript(e)) return;
 
+        var editor = atom.workspace.getActiveTextEditor();
+        var filePath = editor.getPath();
+
         atom.notifications.addInfo('Building');
-        setTimeout(() => {
-            var outputs = commandGetProgram().build();
-            buildView.setBuildOutput(outputs);
-        }, 100);
 
+        parent.build({filePath:filePath}).then((resp)=>{
+            buildView.setBuildOutput(resp.outputs);
+        });
     });
     atom.commands.add('atom-text-editor', 'typescript:go-to-declaration',(e) => {
         if (!commandForTypeScript(e)) return;

lib/main/lang/programManager.js

@@ -15,16 +15,12 @@ var Program = (function () {
             var output = services.getEmitOutput(filePath);
             var success = output.emitOutputStatus === ts.EmitReturnStatus.Succeeded;
             var errors = [];
-            if (success) {
-            }
-            else {
-                console.log('FAILURE ' + filePath + ' emit');
+            if (!success) {
                 var allDiagnostics = services.getCompilerOptionsDiagnostics().concat(services.getSyntacticDiagnostics(filePath)).concat(services.getSemanticDiagnostics(filePath));
                 allDiagnostics.forEach(function (diagnostic) {
                     if (!diagnostic.file)
                         return;
                     var startPosition = diagnostic.file.getLineAndCharacterFromPosition(diagnostic.start);
-                    console.log(diagnostic.file.filename, startPosition.line, startPosition.character, diagnostic.messageText, diagnostic.code, diagnostic.isEarly);
                     errors.push(diagnosticToTSError(diagnostic));
                 });
             }

lib/main/lang/programManager.ts

@@ -43,20 +43,15 @@ export class Program {
         var errors: TSError[] = [];
 
 
-        if (success) {
-            // console.log('SUCCESS ' + filePath);
-        }
-        else {
-            console.log('FAILURE ' + filePath + ' emit');
+        if (!success) {
             var allDiagnostics = services.getCompilerOptionsDiagnostics()
                 .concat(services.getSyntacticDiagnostics(filePath))
                 .concat(services.getSemanticDiagnostics(filePath));
 
             allDiagnostics.forEach(diagnostic => {
                 if (!diagnostic.file) return; // TODO: happens only for 'lib.d.ts' for now
 
-                var startPosition = diagnostic.file.getLineAndCharacterFromPosition(diagnostic.start);
-                console.log(diagnostic.file.filename, startPosition.line, startPosition.character, diagnostic.messageText, diagnostic.code, diagnostic.isEarly);
+                var startPosition = diagnostic.file.getLineAndCharacterFromPosition(diagnostic.start);                
                 errors.push(diagnosticToTSError(diagnostic));
             });
         }

lib/worker/messages.js

@@ -42,3 +42,4 @@ exports.updateText = 'updateText';
 exports.getErrorsForFile = 'getErrorsForFile';
 exports.getCompletionsAtPosition = 'getCompletionsAtPosition';
 exports.getErrorsForFileFiltered = 'getErrorsForFileFiltered';
+exports.build = 'build';

lib/worker/messages.ts

@@ -107,3 +107,12 @@ export interface GetErrorsForFileFilteredQuery{
 export interface GetErrorsForFileFilteredResponse{
     errors: programManager.TSError[];
 }
+
+export var build = 'build'
+export interface BuildQuery{
+    // The filepath of the current typescript file in view
+    filePath:string;
+}
+export interface BuildResponse{
+    outputs: programManager.BuildOutput;
+}

lib/worker/parent.js

@@ -103,3 +103,4 @@ exports.updateText = function (data) { return query(messages.updateText, data);
 exports.getErrorsForFile = function (data) { return query(messages.getErrorsForFile, data); };
 exports.getCompletionsAtPosition = function (data) { return query(messages.getCompletionsAtPosition, data); };
 exports.getErrorsForFileFiltered = function (data) { return query(messages.getErrorsForFileFiltered, data); };
+exports.build = function (data) { return query(messages.build, data); };

lib/worker/parent.ts

@@ -98,7 +98,7 @@ function createId(): string {
     });
 }
 
-function query<Query, Response>(message: string, data: Query) : Promise<Response> {
+function query<Query, Response>(message: string, data: Query): Promise<Response> {
 
     // If we don't have a child exit
     if (!child || !child.stdin.writable) {
@@ -119,7 +119,7 @@ function query<Query, Response>(message: string, data: Query) : Promise<Response
     return defer.promise;
 }
 
-export interface Exec<Query,Response> {
+export interface Exec<Query, Response> {
     (data: Query): Promise<Response>;
 }
 
@@ -147,3 +147,6 @@ export var getCompletionsAtPosition: Exec<messages.GetCompletionsAtPositionQuery
 
 export var getErrorsForFileFiltered: Exec<messages.GetErrorsForFileFilteredQuery, messages.GetErrorsForFileFilteredResponse>
     = (data) => query(messages.getErrorsForFileFiltered, data);
+
+export var build: Exec<messages.BuildQuery, messages.BuildResponse>
+    = (data) => query(messages.build, data);

lib/worker/workerProcess.js

@@ -47,3 +47,8 @@ responders[messages.getErrorsForFileFiltered] = function (data) {
         errors: programManager.getErrorsForFileFiltered(data.filePath)
     };
 };
+responders[messages.build] = function (data) {
+    return {
+        outputs: programManager.getOrCreateProgram(data.filePath).build()
+    };
+};

lib/worker/workerProcess.ts

@@ -67,3 +67,9 @@ responders[messages.getErrorsForFileFiltered] = (data: messages.GetErrorsForFile
         errors: programManager.getErrorsForFileFiltered(data.filePath)
     };
 }
+
+responders[messages.build] = (data: messages.BuildQuery): messages.BuildResponse => {
+    return {
+        outputs: programManager.getOrCreateProgram(data.filePath).build()
+    };
+}