Skip to content

Be Async #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks done
basarat opened this issue Jan 28, 2015 · 5 comments
Closed
6 tasks done

Be Async #27

basarat opened this issue Jan 28, 2015 · 5 comments
Assignees
@basarat
Labels
category:performance
Milestone
2 Second Cut

Comments

@basarat
Copy link
Member

basarat commented Jan 28, 2015

Using the language service in the UI thread is slow. Solution : run it out of process.

Tasks:

  • hover tooltip
  • errors for files
  • Build
  • Use Promises not callbacks in UI thread (Atom comes with a version that has native Promise. If possible use that and make your code async.)
  • linter
  • autocomplete
@basarat basarat added the task label Jan 28, 2015
@basarat basarat added this to the FirstCut milestone Jan 28, 2015
@basarat basarat added wishlist and removed task labels Jan 28, 2015
@basarat basarat removed this from the FirstCut milestone Jan 28, 2015
@basarat basarat changed the title Faster load times Be Async Jan 28, 2015
@basarat
Copy link
Member Author

basarat commented Jan 30, 2015

Maybe wait on this : microsoft/TypeScript#1857

Update: Would be good to have. But it is not the issue here.

@basarat basarat mentioned this issue Jan 31, 2015
Closed
@basarat basarat added this to the 2 Second Cut milestone Feb 4, 2015
basarat referenced this issue Feb 5, 2015
@csnover
Allow all compiler options
8f98c7f 
Fixes #48.
@basarat basarat self-assigned this Feb 5, 2015
basarat added a commit that referenced this issue Feb 5, 2015
@basarat
Use promises for host -> child queries.
bda36cf 
refs #27
closes #19
@basarat
Copy link
Member Author

basarat commented Feb 5, 2015

Note: Using the native promise that comes with atom. Reason is that native will be more optimized.

basarat added a commit that referenced this issue Feb 5, 2015
@basarat
perf: autocomplete is now async
1dacffc 
refs #27
@basarat
Copy link
Member Author

basarat commented Feb 5, 2015

@csnover you should definitely try it now. A sync autocomplete completion list query was too slow. Now that its out of process the whole experience is 🚀

basarat added a commit that referenced this issue Feb 5, 2015
@basarat
pref: make linter asyc
303f813 
refs #27
@basarat
Copy link
Member Author

basarat commented Feb 5, 2015

@csnover this 303f813 is a nice example if you have any doubts about the async architecture. I do plan to decrease this minor ceremony between worker / parent at some point (as it simply adds chances of errors)

basarat added a commit that referenced this issue Feb 5, 2015
@basarat
pref: build is now async. This means you can start a build and *still…
e17f40f 
…* continue to do your work.

refs #27
TIP: don't have any `console.log` anymore in programManager
@basarat basarat assigned basarat and unassigned basarat Feb 5, 2015
basarat added a commit that referenced this issue Feb 6, 2015
@basarat
tooltips (the last sync thing I know of) are now async \o/ refs #27
cad6e18 
Also starts work on ref #52. Will be removing "messages.ts" as its almost redundant in the new mechanism.
@basarat
Copy link
Member Author

basarat commented Feb 6, 2015

I'll track documenting this in a seperate issue.

@basarat basarat closed this as completed Feb 6, 2015
@basarat basarat mentioned this issue Feb 6, 2015
Closed
4 tasks
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@basarat basarat

Labels
category:performance
Projects
None yet
Milestone
2 Second Cut
Development

No branches or pull requests
1 participant
@basarat