Skip to content

Commit 9b22b84

Browse files
committed
Remove the convertible converter since it's not really used anywhere and it's easier to implement Parse(...) than IConvertible on a type
1 parent 75293b5 commit 9b22b84

2 files changed

Lines changed: 0 additions & 28 deletions

File tree

CliFx.Generators/Emitters/CommandDescriptor.cs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -121,19 +121,6 @@ type is INamedTypeSymbol namedConstructable
121121
""";
122122
}
123123

124-
// Implements IConvertible
125-
if (
126-
type.AllInterfaces.Any(i =>
127-
i.ContainingNamespace?.Name == "System" && i.Name == "IConvertible"
128-
)
129-
)
130-
{
131-
// lang=csharp
132-
return $"""
133-
new global::CliFx.Activation.ConvertibleScalarInputConverter<{type.GetGloballyQualifiedName()}>()
134-
""";
135-
}
136-
137124
return null;
138125
}
139126

CliFx/Activation/ConvertibleScalarInputConverter.cs

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)