-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calibrations stats for COPD #1087
Conversation
Hi @mnjowe Could I just double-check that the changes to the calibration figures that this code change brings in, are already include in the write-up document? If so, please do 'Approve' the review of this and then I'll merge it. |
@tbhallett I'm re-running this file now. I will confirm the results after it has finished. Thanks |
@tbhallett Would you like me to review the updated graphs to check I am happy with them ? Happy to do so if you show me the link to them @mnjowe |
@andrew-phillips-1, Yes I would be happy if you take a look at them. I will share you the link once I'm done running the simulation. Thanks |
…alibrations. Logging COPD logs in copd calibration
@tbhallett and @andrew-phillips-1 . I've made some minor changes to both the calibration and analyses file - see the commit above. I'm also attaching the COPD writeup with updated plots and have also added the modal outputs values in the modal outputs table. The plots haven't changed that much. @tbhallett hope when we agree on the updated plots you will also update the write-up on tlo website. Thanks |
Just seeing that for relative rate of death according to COPD we are using 2023 data(Mannino et al 2003 ) . Correcting calibration plot on relative deaths now |
@andrew-phillips-1 and @tbhallett . Kindly find attached, the updated write-up. Thanks |
Thanks @mnjowe (and @tbhallett) These generally look good. For the last two graphs, have the results changed much from the ones we were looking at when this was being developed ? If so, I can't recall our discussions on how we reconciled ourselves to the large differences between data and model. The difference goes one way in the second last graph and the other way in the last graph. (Incidentally, if the last graph is "relative rate" then the units should not include the "per 100 person years". It would be helpful if the footnote for each graph mentions the reference for the data source (if you still have this). |
Hi @andrew-phillips-1 . Thanks for your feedback on this. These plots are almost the same with the last plots when COPD was being developed. For those two last calibration plots, we agreed to just to include them in the write-up BUT trust the modal GBD plots on deaths if we're looking at deaths calibration (@tbhallett correct me if I'm missing something). |
Ah yes @mnjowe thanks. I now recall that discussion. That seems fine. For the last graph since it is a relative rate perhaps we could plot on a log scale ? |
I'm adding the docx to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to the outputs. I think we can now merge this
Fixes #1085