Skip to content

Commit 64053e2

Browse files
Merge branch 'integ_49T2+' into merge_49T2+
2 parents 13d0518 + 3b5495d commit 64053e2

File tree

117 files changed

+42780
-21635
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

117 files changed

+42780
-21635
lines changed

docs/Tools.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ The check\_commit\_ial script compiles, executes IAL test cases and compare the
2222

2323
Script options can be displayed with the -h option.
2424

25-
Before being usable, the AROME model must be installed following the [tools/INSTALL\_pack\_ial.md file](../tools/INSTALL_pack\_ial.md).
25+
Before being usable, some packages must be installed following the [tools/INSTALL.md file](../tools/INSTALL.md).
2626

2727
### check\_commit\_mesonh.sh
2828

src/arome/aux/mode_msg.F90

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ SUBROUTINE PRINT_MSG_1LINE(KVERB, HDOMAIN, HSUBR, HMSG)
2929

3030
CALL PRINT_MSG_MULTI(KVERB, HDOMAIN, HSUBR, [HMSG])
3131

32-
ENDSUBROUTINE PRINT_MSG_1LINE
32+
END SUBROUTINE PRINT_MSG_1LINE
3333

3434
SUBROUTINE PRINT_MSG_MULTI_CMNHMSG(KVERB, HDOMAIN, HSUBR)
3535
INTEGER, INTENT(IN) :: KVERB !Verbosity level

src/arome/conv/convect_chem_transport.F90

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ SUBROUTINE CONVECT_CHEM_TRANSPORT( CVPEXT, D, NSV, KCH, PCH1, PCH1C, &
9595
INTEGER :: JI ! horizontal loop index
9696
INTEGER :: JK, JKP ! vertical loop index
9797
INTEGER :: JN ! chemical tracer loop index
98+
INTEGER :: JCH
9899
INTEGER :: JSTEP ! fractional time loop index
99100
INTEGER :: JKLD, JKLP, JKMIN, JKMAX, JKMAX2 ! loop index for levels
100101
!
@@ -212,7 +213,9 @@ SUBROUTINE CONVECT_CHEM_TRANSPORT( CVPEXT, D, NSV, KCH, PCH1, PCH1C, &
212213
!* 4. Final closure (environmental) computations
213214
! ------------------------------------------
214215
!
215-
PCH1C(D%NIB:D%NIE,IKB:IKE,1:KCH) = PCH1(D%NIB:D%NIE,IKB:IKE,1:KCH) ! initialize adjusted envir. values
216+
DO JCH = 1, KCH
217+
PCH1C(:,IKB:IKE,JCH) = PCH1(:,IKB:IKE,JCH) ! initialize adjusted envir. values
218+
ENDDO
216219
!
217220
DO JK = IKB, IKE
218221
DO JI=D%NIB,D%NIE
@@ -233,8 +236,10 @@ SUBROUTINE CONVECT_CHEM_TRANSPORT( CVPEXT, D, NSV, KCH, PCH1, PCH1C, &
233236
ENDDO
234237
ENDDO
235238
!
236-
ZCH1MFIN(D%NIB:D%NIE,1:D%NKT,1:KCH) = 0.
237-
ZCH1MFOUT(D%NIB:D%NIE,1:D%NKT,1:KCH) = 0.
239+
DO JCH = 1, KCH
240+
ZCH1MFIN(:,1:D%NKT,JCH) = 0.
241+
ZCH1MFOUT(:,1:D%NKT,JCH) = 0.
242+
ENDDO
238243
!
239244
DO JSTEP = 1, KFTSTEPS ! Enter the fractional time step loop
240245
!

src/arome/conv/convect_closure.F90

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ SUBROUTINE CONVECT_CLOSURE( KLON, KLEV, &
146146
REAL, DIMENSION(KLON,KLEV), INTENT(INOUT):: PDTEVRF! downdraft evaporation rate
147147
REAL, DIMENSION(KLON,KLEV), INTENT(OUT) :: PPRLFLX! liquid precip flux
148148
REAL, DIMENSION(KLON,KLEV), INTENT(OUT) :: PPRSFLX! solid precip flux
149+
149150
!
150151
!* 0.2 Declarations of local variables :
151152
!
@@ -156,6 +157,7 @@ SUBROUTINE CONVECT_CLOSURE( KLON, KLEV, &
156157
INTEGER :: JITER ! iteration loop index
157158
INTEGER :: JSTEP ! fractional time loop index
158159
REAL :: ZCPORD, ZRDOCP ! C_pd / R_d, R_d / C_pd
160+
REAL :: ZEPS
159161
!
160162
REAL, DIMENSION(KLON,KLEV) :: ZTHLC ! convectively adjusted
161163
! grid scale enthalpy
@@ -203,14 +205,15 @@ SUBROUTINE CONVECT_CLOSURE( KLON, KLEV, &
203205
LOGICAL, DIMENSION(KLON) :: GWORK1, GWORK3! work arrays
204206
LOGICAL, DIMENSION(KLON,KLEV) :: GWORK4 ! work array
205207
!
208+
REAL(KIND=JPHOOK) :: ZHOOK_HANDLE
206209
!
210+
#include "convect_closure_thrvlcl.h"
207211
!-------------------------------------------------------------------------------
208212
!
209213
!* 0.2 Initialize local variables
210214
! ----------------------------
211215
!
212216
!
213-
REAL(KIND=JPHOOK) :: ZHOOK_HANDLE
214217
IF (LHOOK) CALL DR_HOOK('CONVECT_CLOSURE',0,ZHOOK_HANDLE)
215218
PSPR(:) = 0.
216219
ZTIMC(:,:) = 0.
@@ -225,6 +228,7 @@ SUBROUTINE CONVECT_CLOSURE( KLON, KLEV, &
225228
GWORK4(:,:) = .FALSE.
226229
ILCL(:) = KLCL(:)
227230
!
231+
ZEPS = XRD / XRV
228232
ZCPORD = XCPD / XRD
229233
ZRDOCP = XRD / XCPD
230234
!
@@ -545,10 +549,11 @@ SUBROUTINE CONVECT_CLOSURE( KLON, KLEV, &
545549
! that in routine TRIGGER_FUNCT
546550
! ---------------------------------------------
547551
!
548-
CALL CONVECT_CLOSURE_THRVLCL( KLON, KLEV, &
549-
PPRES, PTHC, PRWC, PZ, GWORK1, &
550-
ZTHLCL, ZRVLCL, ZZLCL, ZTLCL, ZTELCL, &
551-
ILCL, KDPL, KPBL )
552+
CALL ABOR1('FIXME: THE INTERFACE IS WRONG')
553+
!CALL CONVECT_CLOSURE_THRVLCL( KLON, KLEV, &
554+
!PPRES, PTHC, PRWC, PZ, GWORK1, &
555+
!ZTHLCL, ZRVLCL, ZZLCL, ZTLCL, ZTELCL, &
556+
!ILCL, KDPL, KPBL )
552557
!
553558
!
554559
ZTLCL(:) = MAX( 230., MIN( 335., ZTLCL(:) ) ) ! set some overflow bounds
@@ -565,7 +570,9 @@ SUBROUTINE CONVECT_CLOSURE( KLON, KLEV, &
565570
ZPI(:) = MAX( 0.95, MIN( 1.5, ZPI(:) ) )
566571
ZWORK1(:) = XP00 / ZPI(:) ** ZCPORD ! pressure at LCL
567572
!
568-
CALL CONVECT_SATMIXRATIO( KLON, ZWORK1, ZTELCL, ZWORK3, ZLV, ZLS, ZCPH )
573+
DO JI = 1, IIE
574+
CALL CONVECT_SATMIXRATIO( ZWORK1(JI), ZTELCL(JI), ZEPS, ZWORK3(JI), ZLV(JI), ZLS(JI), ZCPH(JI) )
575+
END DO
569576
ZWORK3(:) = MIN( .1, MAX( 0., ZWORK3(:) ) )
570577
!
571578
! compute theta_e updraft undilute
@@ -593,7 +600,9 @@ SUBROUTINE CONVECT_CLOSURE( KLON, KLEV, &
593600
ZWORK2(JI) = PTHC(JI,JK) / ZPI(JI)
594601
END DO
595602
!
596-
CALL CONVECT_SATMIXRATIO( KLON, PPRES(:,JK), ZWORK2, ZWORK3, ZLV, ZLS, ZCPH )
603+
DO JI = 1, IIE
604+
CALL CONVECT_SATMIXRATIO( PPRES(JI,JK), ZWORK2(JI), ZEPS, ZWORK3(JI), ZLV(JI), ZLS(JI), ZCPH(JI) )
605+
END DO
597606
!
598607
!
599608
DO JI = 1, IIE
@@ -659,4 +668,7 @@ SUBROUTINE CONVECT_CLOSURE( KLON, KLEV, &
659668
!
660669
!
661670
IF (LHOOK) CALL DR_HOOK('CONVECT_CLOSURE',1,ZHOOK_HANDLE)
671+
CONTAINS
672+
INCLUDE "convect_satmixratio.h"
673+
!
662674
END SUBROUTINE CONVECT_CLOSURE

src/arome/conv/convect_closure_adjust_shal.F90

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@ SUBROUTINE CONVECT_CLOSURE_ADJUST_SHAL( CVPEXT, D, PADJ, &
9393
! specified degree of stabilization
9494
! ----------------------------------------------------
9595
!
96-
DO JK = IKB + 1, IKE
97-
DO JI = D%NIB, D%NIE
98-
PUMF(JI,JK) = PZUMF(JI,JK) * PADJ(JI)
99-
PUER(JI,JK) = PZUER(JI,JK) * PADJ(JI)
100-
PUDR(JI,JK) = PZUDR(JI,JK) * PADJ(JI)
101-
ENDDO
102-
END DO
96+
DO JK = IKB + 1, IKE
97+
DO JI = D%NIB, D%NIE
98+
PUMF(JI,JK) = PZUMF(JI,JK) * PADJ(JI)
99+
PUER(JI,JK) = PZUER(JI,JK) * PADJ(JI)
100+
PUDR(JI,JK) = PZUDR(JI,JK) * PADJ(JI)
101+
ENDDO
102+
END DO
103103
!
104104
IF (LHOOK) CALL DR_HOOK('CONVECT_CLOSURE_ADJUST_SHAL',1,ZHOOK_HANDLE)
105105
END SUBROUTINE CONVECT_CLOSURE_ADJUST_SHAL

0 commit comments

Comments
 (0)