Skip to content

Commit 338b4c4

Browse files
authored
Fix test that breaks with latest axios version (#1824)
* Fix test that broke with latest axios version * Remove unnecessary async call
1 parent eb3498f commit 338b4c4

File tree

4 files changed

+19
-13
lines changed

4 files changed

+19
-13
lines changed

static/js/admin/vue-cdr-admin/tests/unit/permissions-editor/patronRoles.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ describe('patronRoles.vue', () => {
7373

7474
stubDataSaveResponse();
7575
await wrapper.find('#is-submitting').trigger('click');
76-
moxios.wait(async () => {
77-
let request = moxios.requests.mostRecent()
76+
moxios.wait(() => {
77+
let request = moxios.requests.mostRecent();
7878
expect(request.config.method).toEqual('put');
7979
expect(JSON.parse(request.config.data)).toEqual(
8080
{ roles: assigned_roles, deleted: false, embargo: embargo_date, assignedTo: UUID }

static/js/vue-cdr-access/package-lock.json

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

static/js/vue-cdr-access/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"dependencies": {
1212
"@samvera/clover-iiif": "^2.10.2",
1313
"@vueuse/head": "^2.0.0",
14-
"axios": "^0.28.1",
14+
"axios": "^1.7.7",
1515
"canvas": "^2.11.2",
1616
"datatables.net": "^1.13.11",
1717
"datatables.net-bm": "^1.13.11",

static/js/vue-cdr-access/tests/unit/singleUseLink.spec.js

+11-5
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,17 @@ describe('singleUseLink.vue', () => {
5555

5656
moxios.wait(async () => {
5757
await wrapper.find('#single-use-link').trigger('click');
58-
expect(wrapper.find('.download-link-wrapper').exists()).toBe(true);
59-
expect(wrapper.find('.download-link-wrapper div').text())
60-
.toEqual(`Created link ${response_date.key} expires in 1 day`);
61-
expect(wrapper.find('.download-link-wrapper a').exists()).toBe(true); // Copy button
62-
done();
58+
59+
moxios.wait(() => {
60+
let request = moxios.requests.mostRecent();
61+
62+
expect(request.config.method).toEqual('post');
63+
expect(wrapper.find('.download-link-wrapper').exists()).toBe(true);
64+
expect(wrapper.find('.download-link-wrapper div').text())
65+
.toEqual(`Created link ${response_date.key} expires in 1 day`);
66+
expect(wrapper.find('.download-link-wrapper a').exists()).toBe(true); // Copy button
67+
done();
68+
});
6369
});
6470
});
6571

0 commit comments

Comments
 (0)