Skip to content

Commit 48cd5aa

Browse files
authored
Merge pull request #1339 from UNC-Libraries/bxc-3449-jena
BXC-3449 - Update to jena 4.4.0
2 parents 971e304 + 271f63a commit 48cd5aa

File tree

11 files changed

+21
-41
lines changed

11 files changed

+21
-41
lines changed

deposit-app/src/main/webapp/WEB-INF/service-context.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,6 @@
202202

203203
<bean id="sparqlQueryService" class="edu.unc.lib.boxc.model.fcrepo.sparql.FusekiSparqlQueryServiceImpl">
204204
<property name="fusekiQueryURL" value="${fuseki.baseUri}" />
205-
<property name="httpClientConnectionManager" ref="multiThreadedHttpConnectionManager" />
206205
</bean>
207206

208207
<!-- Initialize access control dependencies -->

model-fcrepo/src/main/java/edu/unc/lib/boxc/model/fcrepo/sparql/FusekiSparqlQueryServiceImpl.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525

2626
import edu.unc.lib.boxc.model.api.sparql.SparqlQueryService;
2727

28+
import java.lang.reflect.Method;
29+
2830
/**
2931
* Service for executing sparql queries against a Fuseki backend
3032
*
@@ -34,24 +36,17 @@
3436
public class FusekiSparqlQueryServiceImpl implements SparqlQueryService {
3537

3638
private String fusekiQueryURL;
37-
private CloseableHttpClient httpClient;
38-
private HttpClientConnectionManager httpClientConnectionManager;
3939

4040
@Override
4141
public QueryExecution executeQuery(String queryString) {
4242
Query query = QueryFactory.create(queryString);
4343

44-
return QueryExecutionFactory.sparqlService(fusekiQueryURL, query, httpClient);
44+
return QueryExecution.service(fusekiQueryURL)
45+
.query(query)
46+
.build();
4547
}
4648

4749
public void setFusekiQueryURL(String fusekiQueryURL) {
4850
this.fusekiQueryURL = fusekiQueryURL;
4951
}
50-
51-
public void setHttpClientConnectionManager(HttpClientConnectionManager manager) {
52-
this.httpClientConnectionManager = manager;
53-
this.httpClient = HttpClients.custom()
54-
.setConnectionManager(httpClientConnectionManager)
55-
.build();
56-
}
5752
}

pom.xml

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@
124124
<embedded-redis.version>0.7.3</embedded-redis.version>
125125
<solr.version>8.10.1</solr.version>
126126
<metrics.version>5.0.0</metrics.version>
127-
<jena.version>3.17.0</jena.version>
128-
<jena.fuseki.version>3.17.0</jena.fuseki.version>
127+
<jena.version>4.4.0</jena.version>
128+
<jena.fuseki.version>4.4.0</jena.fuseki.version>
129129

130130
<fcrepo-camel.version>5.0.0</fcrepo-camel.version>
131131
<camel.version>2.25.4</camel.version>
@@ -1004,25 +1004,6 @@
10041004
</exclusion>
10051005
</exclusions>
10061006
</dependency>
1007-
<dependency>
1008-
<groupId>org.apache.jena</groupId>
1009-
<artifactId>jena-osgi</artifactId>
1010-
<version>${jena.version}</version>
1011-
<exclusions>
1012-
<exclusion>
1013-
<groupId>log4j</groupId>
1014-
<artifactId>log4j</artifactId>
1015-
</exclusion>
1016-
<exclusion>
1017-
<groupId>org.slf4j</groupId>
1018-
<artifactId>slf4j-log4j12</artifactId>
1019-
</exclusion>
1020-
<exclusion>
1021-
<groupId>commons-codec</groupId>
1022-
<artifactId>commons-codec</artifactId>
1023-
</exclusion>
1024-
</exclusions>
1025-
</dependency>
10261007

10271008
<!-- Logging -->
10281009
<dependency>
@@ -1070,6 +1051,12 @@
10701051
<artifactId>fcrepo-auth-common</artifactId>
10711052
<version>${fcrepo4.version}</version>
10721053
<scope>test</scope>
1054+
<exclusions>
1055+
<exclusion>
1056+
<groupId>org.apache.jena</groupId>
1057+
<artifactId>jena-arq</artifactId>
1058+
</exclusion>
1059+
</exclusions>
10731060
</dependency>
10741061
<dependency>
10751062
<groupId>org.glassfish.grizzly</groupId>

services-camel-app/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@
8686
<groupId>org.apache.camel</groupId>
8787
<artifactId>camel-jackson</artifactId>
8888
</exclusion>
89+
<exclusion>
90+
<groupId>org.apache.jena</groupId>
91+
<artifactId>jena-osgi</artifactId>
92+
</exclusion>
8993
</exclusions>
9094
</dependency>
9195

services-camel-app/src/main/java/edu/unc/lib/boxc/services/camel/util/OrderedSetAggregationStrategy.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@ public class OrderedSetAggregationStrategy implements AggregationStrategy {
3636
@Override
3737
public Exchange aggregate(Exchange oldExchange, Exchange newExchange) {
3838
if (oldExchange == null) {
39-
log.error("Starting new ordered set batch");
39+
log.debug("Starting new ordered set batch");
4040
var orderedSet = new LinkedHashSet<>();
4141
orderedSet.add(newExchange.getIn().getBody());
4242
newExchange.getIn().setBody(orderedSet);
4343
return newExchange;
4444
} else {
4545
var orderedSet = oldExchange.getIn().getBody(Set.class);
4646
orderedSet.add(newExchange.getIn().getBody());
47-
log.error("Added to batch, now contains {}", orderedSet.size());
47+
log.debug("Added to batch, now contains {}", orderedSet.size());
4848
return oldExchange;
4949
}
5050
}

services-camel-app/src/main/webapp/WEB-INF/service-context.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@
102102

103103
<bean id="sparqlQueryService" class="edu.unc.lib.boxc.model.fcrepo.sparql.FusekiSparqlQueryServiceImpl">
104104
<property name="fusekiQueryURL" value="${fuseki.baseUri}" />
105-
<property name="httpClientConnectionManager" ref="httpClientConnectionManager" />
106105
</bean>
107106

108107
<bean id="contentPathFactory" class="edu.unc.lib.boxc.model.fcrepo.services.ContentPathFactoryImpl"

services-camel-app/src/test/java/edu/unc/lib/boxc/services/camel/triplesReindexing/TriplesReindexingRouterIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ public void setUp() throws Exception {
136136

137137
final Dataset ds = new DatasetImpl(fusekiModel);
138138
fusekiServer = FusekiServer.create()
139-
.setPort(Integer.parseInt(fusekiPort))
140-
.setContextPath("/fuseki")
139+
.port(Integer.parseInt(fusekiPort))
140+
.contextPath("/fuseki")
141141
.add("/test", ds)
142142
.build();
143143
fusekiServer.start();

services-camel-app/src/test/resources/triples-reindexing-it-context.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141

4242
<bean id="sparqlQueryService" class="edu.unc.lib.boxc.model.fcrepo.sparql.FusekiSparqlQueryServiceImpl" >
4343
<property name="fusekiQueryURL" value="${triplestore.datasetUri}" />
44-
<property name="httpClientConnectionManager" ref="httpClientConnectionManager" />
4544
</bean>
4645

4746
<bean id="triplesUpdateJmsTemplate" class="org.springframework.jms.core.JmsTemplate">

web-access-app/src/main/webapp/WEB-INF/access-fedora-context.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959

6060
<bean id="sparqlQueryService" class="edu.unc.lib.boxc.model.fcrepo.sparql.FusekiSparqlQueryServiceImpl">
6161
<property name="fusekiQueryURL" value="${fuseki.baseUri}" />
62-
<property name="httpClientConnectionManager" ref="httpClientConnectionManager" />
6362
</bean>
6463

6564
<!-- Initialize access control dependencies -->

web-admin-app/src/main/webapp/WEB-INF/access-fedora-context.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242

4343
<bean id="sparqlQueryService" class="edu.unc.lib.boxc.model.fcrepo.sparql.FusekiSparqlQueryServiceImpl">
4444
<property name="fusekiQueryURL" value="${fuseki.baseUri}" />
45-
<property name="httpClientConnectionManager" ref="httpClientConnectionManager" />
4645
</bean>
4746

4847
<!-- Initialize access control dependencies -->

web-services-app/src/main/webapp/WEB-INF/access-fedora-context.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
<bean id="sparqlQueryService" class="edu.unc.lib.boxc.model.fcrepo.sparql.FusekiSparqlQueryServiceImpl">
1616
<property name="fusekiQueryURL" value="${fuseki.baseUri}" />
17-
<property name="httpClientConnectionManager" ref="httpClientConnectionManager" />
1817
</bean>
1918

2019
<!-- Initialize access control dependencies -->

0 commit comments

Comments
 (0)